Spec URL: http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring.spec SRPM URL: http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring-2.29.4-1.fc13.src.rpm Description: gnome-keyring is a program that keep password and other secrets for users. The library libgnome-keyring is used by applications to integrate with the gnome-keyring system. -- Basically, this is a split of gnome-keyring (recent upstream decision), creating separate library with the core. Feel free to propose better description, I'm bad with that. rpmlint passes without warning, package builds fine in koji.
Forgot to add that we will have to add libgnome-keyring dependency to all g-k clients and fix tons of packages in Fedora. This will effectively make decent mess once libgnome-keyring and new gnome-keyring packages will hit rawhide.
(In reply to comment #1) > Forgot to add that we will have to add libgnome-keyring dependency to all g-k > clients and fix tons of packages in Fedora. This will effectively make decent > mess once libgnome-keyring and new gnome-keyring packages will hit rawhide. Not really. Make the library depend on gnome-keyring, voila. You'd probably have a problem with bootstrapping gnome-keyring from scratch if it depends on libgnome-keyring, but that's relatively minor.
You still need a libgnome-keyring-devel BR everywhere...
Right, we can add explicit Require: libgnome-keyring-devel to the gnome-keyring-devel, that might do the trick for the moment. FYI, we have bootstrapping problems in Fedora anyway, circular BR dependency nautilus <--> gnome-disk-utility (pulled in by gvfs, which nautilus depends on), but that's another story.
Package builds fine in mock, and rpmlint is silent: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/libgnome-keyring-*.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings.
package name: ok spec name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec language: ok spec readable: yes upstream source: ok buildable: yes ExcludeArch: none, ok BuildRequires: ok locale handling: none, ok ldconfig: ok system libraries: none, ok relocatable: no, ok directory ownership: ok duplicate files: ok file permissions: ok %clean: ok macro use: ok permissable content: ok large docs: none, ok %doc content: ok header files: ok static libs: none, ok pc files: ok shared libs: ok devel deps: ok libtool archives: none, ok gui apps: no, ok file ownership: ok, but we should figure out how to handle the conflict with the old gnome-keyring package %install: ok utf8 filenames: ok Summary: all looks good, we just need to figure out the conflict with the old gnome-keyring package. Probably add something like Conflicts: gnome-keyring < 2.29.4 Conflicts: gnome-keyring-devel < 2.29.4
Thanks for the review. I've added Conflicts: in libgnome-keyring.spec and explicit Requires: libgnome-keyring in gnome-keyring.spec for both gnome-keyring and gnome-keyring-devel subpackages (as discussed above). This should guarantee good upgrade path without breaking the things. New Spec: http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring.spec New SRPM: http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring-2.29.4-1.fc13.src.rpm
Looks good. Approved.
New Package CVS Request ======================= Package Name: libgnome-keyring Short Description: Framework for managing passwords and other secrets Owners: tbzatek Branches: devel InitialCC:
cvs done.
(In reply to comment #10) > cvs done. Thanks! libgnome-keyring-2.29.4-1.fc13 has been built: http://koji.fedoraproject.org/koji/buildinfo?buildID=149812