Spec URL: http://akurtakov.fedorapeople.org/plexus-io.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-io-1.0-0.1.a5.1.fc12.src.rpm Description: Plexus IO is a set of plexus components, which are designed for use in I/O operations.
I made a full review. Here are my comments, questions etc: * Package does not build in mock. It pulls gcj. We want openjdk. I added that BR fol the rest of the review. As far as I know, all java packages need these BR's and R's: http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires * Additionally, the guidelines tell us to include these R's for maven: http://fedoraproject.org/wiki/Packaging:Java#maven * rpmlint says plexus-io.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-io Is this ignorable? Why? ! javadoc package does not require the main package. (just a warning. I don't know if this is intentional) ? Shouldn't the release tag just be 0.1.a5%{?dist} ! For macro consistency plexus-io can be replaced by %{name} at two places
(In reply to comment #1) > I made a full review. Here are my comments, questions etc: > > * Package does not build in mock. It pulls gcj. We want openjdk. I added that > BR fol the rest of the review. > As far as I know, all java packages need these BR's and R's: > http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires Fixed. > > * Additionally, the guidelines tell us to include these R's for maven: > http://fedoraproject.org/wiki/Packaging:Java#maven Fixed. > > * rpmlint says > plexus-io.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-io > Is this ignorable? Why? This is the place where mvn looks for fragments. And they are clearly non conffile because users should not edit them. > > ! javadoc package does not require the main package. (just a warning. I don't > know if this is intentional) Perfectly ok. There are many times when you want to install just the javadoc for local reference and studing the API without any need to use it. > > ? Shouldn't the release tag just be 0.1.a5%{?dist} Fixed. > > ! For macro consistency plexus-io can be replaced by %{name} at two places Fixed Spec URL: http://akurtakov.fedorapeople.org/plexus-io.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-io-1.0-0.2.a5.fc12.src.rpm
Thanks! Good to go. -------------------------------------------- This package (plexus-io) is APPROVED by oget --------------------------------------------
New Package CVS Request ======================= Package Name: plexus-io Short Description: Plexus IO Components Owners: akurtakov Branches: InitialCC:
CVS Done
Built in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=148397