Bug 550105 - Review Request: ghc-parsec - Haskell parser library
Summary: Review Request: ghc-parsec - Haskell parser library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Rakesh Pandit
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-23 15:45 UTC by Jens Petersen
Modified: 2013-11-13 13:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-11 12:37:55 UTC
Type: ---
rpandit: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jens Petersen 2009-12-23 15:45:39 UTC
Spec URL: http://petersen.fedorapeople.org/ghc-parsec/ghc-parsec.spec
SRPM URL: http://petersen.fedorapeople.org/ghc-parsec/ghc-parsec-2.1.0.1-1.fc12.src.rpm
Description: Haskell parser library

Part of haskell-platform, currently need for ghc-6.12.1
to build ghc-network, haskell-platform, and darcs I think.

Comment 1 Jens Petersen 2010-01-10 15:45:38 UTC
Spec URL: http://petersen.fedorapeople.org/ghc-parsec/ghc-parsec.spec
SRPM URL:
http://petersen.fedorapeople.org/ghc-parsec/ghc-parsec-2.1.0.1-2.fc12.src.rpm

Updated to simple ghc-rpm-macros-0.5.1 macros.

Comment 2 Rakesh Pandit 2010-01-10 17:44:27 UTC
[x] Build - http://koji.fedoraproject.org/koji/taskinfo?taskID=1912376 fine
[x] rpmlint - ok 

ghc-parsec.src: W: no-cleaning-of-buildroot %install
ghc-parsec.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[rakesh@dhcp1-96 SPECS]$ rpmlint /home/rakesh/rpmbuild/RPMS/i686/ghc-parsec-2.1.0.1-2.fc13.i686.rpm
ghc-parsec.i686: W: unstripped-binary-or-object /usr/lib/ghc-6.12.1/parsec-2.1.0.1/libHSparsec-2.1.0.1-ghc6.12.1.so
ghc-parsec.i686: W: executable-stack /usr/lib/ghc-6.12.1/parsec-2.1.0.1/libHSparsec-2.1.0.1-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Ignore

[rakesh@dhcp1-96 SPECS]$ rpmlint /home/rakesh/rpmbuild/RPMS/i686/ghc-parsec-devel-2.1.0.1-2.fc13.i686.rpm
ghc-parsec-devel.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Ignore

[rakesh@dhcp1-96 SPECS]$ rpmlint /home/rakesh/rpmbuild/RPMS/i686/ghc-parsec-doc-2.1.0.1-2.fc13.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

fine

[rakesh@dhcp1-96 SPECS]$ rpmlint /home/rakesh/rpmbuild/RPMS/i686/ghc-parsec-prof-2.1.0.1-2.fc13.i686.rpm
ghc-parsec-prof.i686: E: devel-dependency ghc-parsec-devel
ghc-parsec-prof.i686: W: no-documentation
ghc-parsec-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.1/parsec-2.1.0.1/libHSparsec-2.1.0.1_p.a
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Ignore

[x] name fine
[x] URL fine
[-] source ok

from srpm f09c7fcbf66c39cc4de2a50dbb1374ba82168b52 (sha1sum)
still to check from http://hackage.haskell.org/ as it went down

[x] spec name fine
[x] license ok (copy present) and source has marking
[x] source tree ok (no binaries present)
[x] archs - fine
[x] spec file legible and in american english
[x] BR's ok
[x] %files ok
[x] folders owned - ok
/usr/share/doc/ghc-mtl-1.1.0.2
/usr/lib/ghc-6.12.1/mtl-1.1.0.2
[x] source builds fine on fedora ghc archs
[x] no bundled dependencies
[x] %clean section ok
[x] filenames - ok (valid)
[x] profiling ok
[x] lib goes to %{_libdir}/ghc-%{ghc_version}/%{pkg_name}-%{version}
[x] new macros

APPROVED

You may ask for cvs request. I have done manual source traversal and it is safe. Will verify whether it is actually from upstream in a while when site is up.

Comment 3 Rakesh Pandit 2010-01-10 17:47:24 UTC
ok verified from upstream. Site is up now.

Comment 4 Jens Petersen 2010-01-11 00:48:10 UTC
Thank you! :)


New Package CVS Request
=======================
Package Name: ghc-parsec
Short Description: Haskell parser library
Owners: petersen
Branches: devel
InitialCC: haskell-sig

Comment 5 Jens Petersen 2010-01-11 12:23:13 UTC
cvs admin done

Comment 6 Jens Petersen 2010-01-11 12:37:55 UTC
Package imported and built.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1913666

Comment 7 Jens Petersen 2010-09-29 05:30:47 UTC
Package Change Request
======================
Package Name: ghc-parsec
New Branches: el6
Owners: petersen
InitialCC: haskell-sig

Comment 8 Kevin Fenzi 2010-09-29 18:41:14 UTC
Git done (by process-git-requests).

Comment 9 Jens Petersen 2013-11-13 05:30:27 UTC
Package Change Request
======================
Package Name: ghc-parsec
New Branches: el5
Owners: petersen
InitialCC: haskell-sig

Comment 10 Gwyn Ciesla 2013-11-13 13:00:50 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.