Fedora Account System
Red Hat Associate
Red Hat Customer
0yum.cron is a /bin/sh script, but contains a few bashisms that will likely break in the unlikely even if someone manages to change /bin/sh to be something other than bash: $ checkbashisms -f 0yum.cron possible bashism in 0yum.cron line 15 (should be '.', not 'source'): source /etc/sysconfig/yum-cron possible bashism in 0yum.cron line 23 (${parm/?/pat[/str]}): if [ "${DAYS_OF_WEEK/$dow/}" == "${DAYS_OF_WEEK}" ]; then possible bashism in 0yum.cron line 23 (should be 'b = a'): if [ "${DAYS_OF_WEEK/$dow/}" == "${DAYS_OF_WEEK}" ]; then possible bashism in 0yum.cron line 29 (should be 'b = a'): if [ "$DOWNLOAD_ONLY" == "yes" ]; then possible bashism in 0yum.cron line 61 (should be >word 2>&1): if ! kill -0 $OTHERPID &>/dev/null; then possible bashism in 0yum.cron line 88 (${parm/?/pat[/str]}): if [ ! "${CLEANDAY/$dow/}" == "${CLEANDAY}" ]; then possible bashism in 0yum.cron line 88 (should be 'b = a'): if [ ! "${CLEANDAY/$dow/}" == "${CLEANDAY}" ]; then possible bashism in 0yum.cron line 93 (should be 'b = a'): if [ "$CHECK_ONLY" == "yes" ]; then possible bashism in 0yum.cron line 99 (should be 'b = a'): if [ "$DOWNLOAD_ONLY" == "yes" ]; then possible bashism in 0yum.cron line 107 (should be 'b = a'): elif [ "$CHECK_FIRST" == "yes" ]; then An easy fix would be to just make the shebang point to /bin/bash.
Good catch, will change the shebang. Possibly the requires too - is bash part of the default requires set?
Yes, it is, and /bin/sh is part of the bash package as well. The dependency on the shebang interpreter should be automatically added by rpmbuild so there should be no need to do anything about it in the specfile.
yum-cron-0.9.2-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/yum-cron-0.9.2-1.fc12
Ville - your simple changes are in the above testing update. If you're happy with it I'll push it to updates.
yum-cron-0.9.2-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update yum-cron'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1794
yum-cron-0.9.2-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.