Bug 550690 - Review Request: libsurl - A library for generating shortened URLs
Summary: Review Request: libsurl - A library for generating shortened URLs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-26 20:38 UTC by Fabian Affolter
Modified: 2010-07-06 17:34 UTC (History)
3 users (show)

Fixed In Version: libsurl-0.7.1-2.fc12
Clone Of:
Environment:
Last Closed: 2010-07-06 17:24:15 UTC
Type: ---
Embargoed:
bugs.michael: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Fabian Affolter 2009-12-26 20:38:07 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/libsurl.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/libsurl-0.5.0-1.fc12.src.rpm

Project URL: http://libsurl.sourceforge.net/

Description:
libsurl is a library for generating short urls (using various online
services like tinyurl.com and bit.ly) suited to use where space is
limited, such as in status messages. surl is the command-line interface
to libsurl, providing most of the functionality in libsurl as well as
additional functionality likely to be of use to command-line users. 

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1891806

rpmlint output:
[fab@localhost SRPMS]$ rpmlint libsurl-0.5.0-1.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@localhost i686]$ rpmlint libsurl*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Fabian Affolter 2010-01-04 10:36:44 UTC
The new spec and SRPM will come soon because 0.7.0 was released.

Comment 2 Fabian Affolter 2010-01-04 10:39:54 UTC
Bug https://bugs.launchpad.net/libsurl/+bug/502887 need to be solved first ;-)

Comment 3 Fabian Affolter 2010-01-04 11:35:26 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/libsurl.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/libsurl-0.7.1-1.fc12.src.rpm


* Mon Jan 04 2010 Fabian Affolter <fabian> - 0.7.1-1
- Updated to new upstream version 0.7.1 to fix issue with make

* Mon Jan 04 2010 Fabian Affolter <fabian> - 0.7.0-1
- Added man pages
- Updated to new upstream version 0.7.0

* Mon Dec 28 2009 Fabian Affolter <fabian> - 0.6.0-1
- Updated to new upstream version 0.6.0

Comment 4 Michael Schwendt 2010-01-11 12:41:03 UTC
> Group:          Applications/Internet

Shared libraries like this still belong into "System Environment/Libraries".


> %{_mandir}/man*/*.gz

Since manual pages are compressed on-the-fly by rpmbuild and the compression tool may change, prefer:  %{_mandir}/man*/*

And move these manual pages into the -devel pages, since they document the library API.


> %files
> %defattr(-,root,root,-)
> %doc AUTHORS ChangeLog COPYING NEWS README

> %files devel
> %defattr(-,root,root,-)
> %doc ChangeLog

Why duplicate the ChangeLog? Including it in just the base package is fine.


> #Tests deactivated because the library checks online URLs
> #%check
> #make check

A good opportunity to make this a conditional build, so you could simply activate the test-suite for local builds with "rpmbuild --with tests libsurl.src.rpm":

%bcond_with tests
%if %{with tests}
%check
make check
%endif


* The %description mentions "surl" without explaining that it is a separate tool to be found in a separate package ("surl").


* The web page mentions that the latest stable release is 0.6.0. No comment is found on 0.7.0 and 0.7.1, not in the tarball either. I've mailed a question about that to the author.

Comment 5 Michael Schwendt 2010-01-11 17:05:36 UTC
Quick reply from Scott Lawrence: The latest stable release should be 0.7.1.

Comment 6 Fabian Affolter 2010-02-09 10:07:43 UTC
Thanks for the review.  I will make an update in the next days.

Comment 7 Fabian Affolter 2010-02-24 22:12:42 UTC
(In reply to comment #4)
> > Group:          Applications/Internet
> Shared libraries like this still belong into "System Environment/Libraries".

Changed

> > %{_mandir}/man*/*.gz
> Since manual pages are compressed on-the-fly by rpmbuild and the compression
> tool may change, prefer:  %{_mandir}/man*/*
> 
> And move these manual pages into the -devel pages, since they document the
> library API.

done

> Why duplicate the ChangeLog? Including it in just the base package is fine.

Removed from devel

> > #Tests deactivated because the library checks online URLs
> > #%check
> > #make check
> 
> A good opportunity to make this a conditional build, so you could simply
> activate the test-suite for local builds with "rpmbuild --with tests
> libsurl.src.rpm":
> 
> %bcond_with tests
> %if %{with tests}
> %check
> make check
> %endif

Added, thanks

> * The %description mentions "surl" without explaining that it is a separate
> tool to be found in a separate package ("surl").

Description changed

Here are the updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/libsurl.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/libsurl-0.7.1-2.fc12.src.rpm

Comment 8 Michael Schwendt 2010-06-20 20:32:40 UTC
libsurl-0.7.1-2.fc12.src.rpm

APPROVED

Comment 9 Fabian Affolter 2010-06-21 05:55:44 UTC
Thanks for your work, Michael.

Comment 10 Fabian Affolter 2010-06-21 05:56:40 UTC
New Package CVS Request
=======================
Package Name: libsurl
Short Description: A library for generating shortened URLs
Owners: fab
Branches: F-12 F-13
InitialCC:

Comment 11 Kevin Fenzi 2010-06-23 01:45:10 UTC
CVS done (by process-cvs-requests.py).

Comment 12 Fedora Update System 2010-06-23 22:21:01 UTC
libsurl-0.7.1-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/libsurl-0.7.1-2.fc12

Comment 13 Fedora Update System 2010-06-23 22:21:08 UTC
libsurl-0.7.1-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libsurl-0.7.1-2.fc13

Comment 14 Fedora Update System 2010-06-24 16:27:09 UTC
libsurl-0.7.1-2.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libsurl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libsurl-0.7.1-2.fc13

Comment 15 Fedora Update System 2010-06-24 16:35:03 UTC
libsurl-0.7.1-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libsurl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libsurl-0.7.1-2.fc12

Comment 16 Fedora Update System 2010-07-06 17:24:09 UTC
libsurl-0.7.1-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2010-07-06 17:34:28 UTC
libsurl-0.7.1-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.