Spec URL: http://melmorabity.fedorapeople.org/packages/gnome-xcf-thumbnailer/gnome-xcf-thumbnailer.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/gnome-xcf-thumbnailer/gnome-xcf-thumbnailer-1.0-1.fc12.src.rpm Description: Thumbnailer for GIMP's own format, XCF files mock is OK, rpmlint is silent both with the SRPM and the debug RPM, not on the binary RPM itself: gnome-xcf-thumbnailer.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/gnome-xcf-thumbnailer.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here Anyway, this can be ignored for GConf files. Note that I need a sponsor, although it's not my first package (see my other review requests 551027 and 551042).
Some minor fix (replaced in %files section %{bindir}/* by %{bindir}/gnome-xcf-thumbailer) : Spec URL : http://melmorabity.fedorapeople.org/packages/gnome-xcf-thumbnailer/gnome-xcf-thumbnailer.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/gnome-xcf-thumbnailer/gnome-xcf-thumbnailer-1.0-2.fc12.src.rpm
I'll review this.
Package revienw : [OK] Package is named according to the Package Naming Guidelines [OK] Specfile name matches %{name}.spec [OK] Package seems to meet Packaging Guidelines [OK] Package successfully compiles and builds into binary RPMs on at least one supported architecture : Builds on koji [OK] Rpmlint output: the warning about "noreplace" config file can be ignored [OK] Package is not relocatable. [OK] License in specfile matches actual License and meets Licensing Guidelines [OK] License file is included in %doc. [OK] Specfile is legible and written in AE [OK] Sourcefile in the Package is the same as provided in the mentioned Source [OK] Package compiles successfully [OK] All build dependencies are listed in BuildRequires [N/A] Specfile handles locales properly [N/A] ldconfig called in %post and %postun if required [N/A] Package owns directorys it creates [OK] Package requires other packages for directories it uses. [OK] Package does not list a file more than once in the %files listing [OK] %files section includes %defattr and permissions are set properly [OK] %clean section is there and contains rm -rf %{buildroot} [OK] Macros are consistently used [OK] Package contains code, or permissable content. [N/A] Large documentation files are in a -doc subpackage [OK] Program runs properly without files listed in %doc [N/A] Header files are in a -devel package [N/A] Static libraries are in a -static package [N/A] Package requires pkgconfig if .pc files are present [N/A] .so-files are put into a -devel subpackage [N/A] Subpackages include fully versioned dependency for the base package [N/A] Any libtool archives (*.la) are removed [N/A] contains desktop file (%{name}.desktop) if it is a GUI application [OK] Package does not own files or directories owned by other packages. [OK] %{buildroot} is removed at beginning of %install [N/A] Filenames are encoded in UTF-8 Also GConf rules are respected : http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf This package is APPROVED
New Package CVS Request ======================= Package Name: gnome-xcf-thumbnailer Short Description: Thumbnailer for GIMP's own format, XCF files Owners: melmorabity Branches: F-11 F-12 InitialCC:
CVS done (by process-cvs-requests.py).
gnome-xcf-thumbnailer-1.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/gnome-xcf-thumbnailer-1.0-2.fc11
gnome-xcf-thumbnailer-1.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/gnome-xcf-thumbnailer-1.0-2.fc12
gnome-xcf-thumbnailer-1.0-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gnome-xcf-thumbnailer'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1434
gnome-xcf-thumbnailer-1.0-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gnome-xcf-thumbnailer'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1511
gnome-xcf-thumbnailer-1.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
gnome-xcf-thumbnailer-1.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.