Bug 551686 - Update fftw to 3.2.2 in Fedora and EPEL
Summary: Update fftw to 3.2.2 in Fedora and EPEL
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fftw
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Conrad Meyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-01 10:51 UTC by Susi Lehtola
Modified: 2010-04-28 15:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-04-28 15:19:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Proposed patch (1.59 KB, patch)
2010-01-01 11:37 UTC, Susi Lehtola
no flags Details | Diff

Description Susi Lehtola 2010-01-01 10:51:31 UTC
The current version of fftw in Fedora is 3.2.1, please update it to 3.2.2.

Also, please update fftw in EPEL to 3.2.2. The version in EPEL is currently 3.1.2; the 3.2 series brings significant speedups. According to bug 471772, the fftw 3.2 series is compatible with the 3.1 series, so no other package rebuild should be necessary.

Comment 1 Susi Lehtola 2010-01-01 11:37:56 UTC
Created attachment 381165 [details]
Proposed patch

Comment 2 Conrad Meyer 2010-01-01 23:32:02 UTC
You can take the EPEL branch of the package if you like, I have no interest in it.

Comment 3 Conrad Meyer 2010-01-01 23:41:50 UTC
I've committed your patch to the devel/ branch (next time, please use a unified diff so it can be applied), and it's now building for F13. When that succeeds I'll start it for F-12.

Thanks!

Comment 4 Susi Lehtola 2010-01-02 00:01:07 UTC
(In reply to comment #3)
> I've committed your patch to the devel/ branch (next time, please use a unified
> diff so it can be applied), and it's now building for F13.

Whoops, looks like I forgot. But still, there's no problem in applying the patch:

$ wget "http://cvs.fedoraproject.org/viewvc/rpms/fftw/devel/fftw.spec?revision=1.27&view=co" -O fftw.spec
$ patch fftw.spec fftw.spec.patch

results in the patched file.


>When that succeeds I'll start it for F-12.
> 
> Thanks!  

No problem!

(In reply to comment #2)
> You can take the EPEL branch of the package if you like, I have no interest in
> it.  

OK, I will.

Comment 5 Conrad Meyer 2010-01-02 00:03:45 UTC
Weird, I guess I'm not familiar enough with patch, sorry. (The 'patch < foo.patch' invocation told me the input was garbage.)

Ok, fftw-3.2.2 is build in F-13.

Comment 6 Susi Lehtola 2010-01-02 00:18:35 UTC
Hmm, 3.1.2 had a %check phase, but new spec files don't have it anymore.. Why?

Comment 7 Conrad Meyer 2010-01-02 00:46:20 UTC
Don't know.

Comment 8 Fedora Update System 2010-01-02 00:52:16 UTC
fftw-3.2.2-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/fftw-3.2.2-1.fc12

Comment 9 Susi Lehtola 2010-01-02 00:53:39 UTC
OK, pushing 3.2.2-2 in a few minutes with added %check phase and a few other minor cosmetical fixes.

Comment 10 Fedora Update System 2010-01-02 07:37:30 UTC
fftw-3.2.2-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/fftw-3.2.2-1.el5

Comment 11 Fedora Update System 2010-01-02 07:37:34 UTC
fftw-3.2.2-1.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/fftw-3.2.2-1.el4

Comment 12 Rex Dieter 2010-01-02 20:15:50 UTC
I object to the fftw3-> fftw rename here, as (primary) EPEL maintainer.

Comment 13 Susi Lehtola 2010-01-02 20:24:09 UTC
(In reply to comment #12)
> I object to the fftw3-> fftw rename here, as (primary) EPEL maintainer.  

Conrad asked me to take over the EPEL branch, so I assumed I was given full control over it. If you still want to maintain the EPEL branch (and push the 3.2 branch in it), I will step back.

As I stated in the mail and the changelog, the current name does not obey the Package Naming Guidelines. There is no difference in the functionality: "yum install fftw(-devel)" and "yum install fftw3(-devel)" both evaluate to the same thing. So I really don't see the problem: the rpmforge compatibility is still there.

Comment 14 Rex Dieter 2010-01-02 20:42:24 UTC
I was already maintainer of the epel branch, Conrad may have just forgotten. :)

While the name is strictly out of concordance with the guidelines, if you insist, I'll ask for a new
fftw3/
cvs module to be created.  But, I think that's beyond what's required here, and would strongly prefer to keep things together in the same fftw/ module. 

See also,

* Tue Jul 10 2007 Rex Dieter <rdieter[AT]fedoraproject.org> 3.1.2-4
- (re)name -> fftw3 (epel-only, for rpmforge compatibility, #246004)

For which your change is undoing.

rpmforge repo has a long history of providing this as fftw3, and it's developers and users have a strong desire to keep things so.  I named this fftw3 with the desire to maximize repo compatibility.

Comment 15 Rex Dieter 2010-01-02 20:54:24 UTC
That all said, I *do* welcome comaintainers to help out whereever possible.  Thank you for that. :)

Comment 16 Susi Lehtola 2010-01-02 20:57:51 UTC
(In reply to comment #14)
> rpmforge repo has a long history of providing this as fftw3, and it's
> developers and users have a strong desire to keep things so.  I named this
> fftw3 with the desire to maximize repo compatibility.  

Yes, but that's really going against the guidelines, see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

Having an Obsoletes: and Provides fftw3(-devel) is not, and it provides a clean upgrade path for rpmforge compatibility. What harm is there *really* about the epel package being called fftw instead of fftw3, when everything written against the fftw3 package names still work as before?

Comment 17 Rex Dieter 2010-01-02 21:12:57 UTC
Honestly, there isn't any *real* harm in the rename, but it was done at request of rpmforge's request.  Please revisit the rpmforge mailing list flames if you want, else please take my word for it.

Comment 18 Conrad Meyer 2010-01-03 20:26:36 UTC
Sorry, Rex is correct, I didn't remember he was the EPEL maintainer. As always, pkgdb is the authoritative source :).

Comment 19 Bug Zapper 2010-03-15 13:44:09 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 13 development cycle.
Changing version to '13'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 20 Fedora Update System 2010-04-01 01:55:19 UTC
fftw-3.2.2-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.