Spec URL: http://rpms.damian.net/SPECS/php-channel-pdepend.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-pdepend-1.0.0-1.fc12.src.rpm Description: PHP Depend PEAR channel
Same notes than for 544660 - Requires php-cli is redundant with php-pear - replace pear.pdepend.org.xml by %{name}.xml (cf PHP Guidelines)
Please fix your spec and I will quickly do the formal review.
Spec URL: http://rpms.damian.net/SPECS/php-channel-pdepend.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-pdepend-1.3-1.fc12.src.rpm - removed php-cli requirement, which is covered by php-pear requirement - changed name of channel xml name - using rest version as version now
Spec URL: http://rpms.damian.net/SPECS/php-channel-pdepend.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-pdepend-1.3-2.fc12.src.rpm forgot to change channel xml filename in %post
in %post: seems %{name}.xml still not used... There some days like this ;) +
This is embarrassing :-) Thank you for your patience Spec URL: http://rpms.damian.net/SPECS/php-channel-pdepend.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-pdepend-1.3-3.fc12.src.rpm
REVIEW: ~ no source files (channel.xml ok, but see notice) * package meets naming * package must meet packaging guidelines * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license (of the packages provided by the channel). * license is open source-compatible (BSD). * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide). * package installs properly * channel (un)registered properly * rpmlint (warnings are ok) : php-channel-pdepend.src: I: checking php-channel-pdepend.noarch: I: checking php-channel-pdepend.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. * final provides are sane: php-channel(pear.pdepend.org) = 1.3 php-channel-pdepend = 1.3-3.fc8 * final requires /usr/bin/pear php-pear(PEAR) * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation * %install start with rm * %clean ok Just a minor diff between channel.xml in src.rpm and upstream one (double / in URL) => you could update it during CVS import. ***** APPROVED *****
New Package CVS Request ======================= Package Name: php-channel-pdepend Short Description: PHP Depend PEAR channel Owners: cdamian Branches: F-11 F-12 InitialCC:
CVS done (by process-cvs-requests.py).
php-channel-pdepend-1.3-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-channel-pdepend-1.3-4.fc12
php-channel-pdepend-1.3-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: php-channel-pdepend New Branches: EL-6 Owners: cdamian
Package Change Request ====================== Package Name: php-channel-pdepend New Branches: EL-7 Owners: llaumgui
Git done (by process-git-requests).
Can you please check, it seems epel7 branch doesn't exist.
Package Change Request ====================== Package Name: php-channel-pdepend New Branches: epel7 Owners: llaumgui