Bug 551912 - Review Request: monodevelop-java - A java plugin for monodevelop
Summary: Review Request: monodevelop-java - A java plugin for monodevelop
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christian Krause
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-03 02:21 UTC by Paul F. Johnson
Modified: 2013-01-09 16:19 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-01-09 16:19:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Paul F. Johnson 2010-01-03 02:21:57 UTC
SRPM URL: http://www.all-the-johnsons.co.uk/fedora/monodevelop-java-2.2-1.fc13.src.rpm
Description: This is a simple Java plugin for monodevelop

Comment 1 Christoph Wickert 2010-01-15 18:36:21 UTC
Please be so kind as to post the spec URL.

Comment 2 Paul F. Johnson 2010-01-17 14:17:47 UTC
SPEC : http://www.all-the-johnsons.co.uk/fedora/monodevelop-java.spec

Comment 3 Christian Krause 2010-01-24 18:06:43 UTC
I've roughly scanned over the package and I've seen a couple of issues. It
would be good if they could be fixed first before I do the full complete
review:

- source files differ from upstream and the source URL does not match the link
on the download page:
http://ftp.novell.com/pub/mono/sources/monodevelop-java/monodevelop-java-2.2.tar.bz2

- License: it looks like that the source files and the COPYING file points to GPLv2+ instead of MIT - please can you check this?

- package does not build (x86_64):
Looking for required packages
Checking for package 'mono-addins'.. found.
Checking for package 'gtk-sharp-2.0'.. ERROR: Package named 'gtk-sharp-2.0' >= 2.12.8 not found.
Try adjusting your PKG_CONFIG_PATH environment variable.
error: Bad exit status from /var/tmp/rpm-tmp.d20ndr (%build)
RPM build errors:

- directory %{_libdir}/monodevelop/AddIns/JavaBinding must be packaged

Comment 6 Christian Krause 2010-02-09 22:49:15 UTC
I've looked at the new package and I've observed the following issues:

1. This packages suffers from the same problem with the moved locales as monodevelop-boo: The translations are not found anymore at all.
https://bugzilla.redhat.com/show_bug.cgi?id=551911#c5

2. There are a couple of minor rpmlint warnings (typos, tabs vs. spaces, ...) (no-binary, no-documentation, configure-... etc. are false positives, they don't need to be fixed)

Please can you fix both of the problems before I do the full official review? Thanks!

Comment 7 Claudio Rodrigo Pereyra DIaz 2010-06-19 00:02:56 UTC
I repackage monodevelop-java to update upstream version 2.4

Spec URL: http://elsupergomez.fedorapeople.org/SPECS/monodevelop-java.spec
SRPM URL:
http://elsupergomez.fedorapeople.org/SRPMS/monodevelop-java-2.4-1.fc13.src.rpm

Please review

FE-NEEDSPONSOR

Thanks!

Comment 8 Paul F. Johnson 2010-06-20 00:03:54 UTC
#7 : Is this based on my srpm?

Comment 9 Claudio Rodrigo Pereyra DIaz 2010-07-28 11:34:25 UTC
(In reply to comment #8)
> #7 : Is this based on my srpm?    

Yes!, is based on your srpm.

Comment 10 Christian Krause 2011-06-07 20:43:56 UTC
Paul, are you still interested getting this package reviewed? 

Claudio, if you want to take over this review, I think the best way would be if you create a new Review Request.

Comment 11 Miroslav Suchý 2012-12-16 13:14:23 UTC
Ping? Any progress here? Or we can close this review?

Comment 12 Claudio Rodrigo Pereyra DIaz 2013-01-09 16:03:15 UTC
Monodevelop from 3.0 and newer not provide a source for this plugin. I suggest to close ticket.

Comment 13 Miroslav Suchý 2013-01-09 16:19:00 UTC
closing per #12


Note You need to log in before you can comment on or make changes to this bug.