SRPM URL: http://www.all-the-johnsons.co.uk/fedora/monodevelop-java-2.2-1.fc13.src.rpm Description: This is a simple Java plugin for monodevelop
Please be so kind as to post the spec URL.
SPEC : http://www.all-the-johnsons.co.uk/fedora/monodevelop-java.spec
I've roughly scanned over the package and I've seen a couple of issues. It would be good if they could be fixed first before I do the full complete review: - source files differ from upstream and the source URL does not match the link on the download page: http://ftp.novell.com/pub/mono/sources/monodevelop-java/monodevelop-java-2.2.tar.bz2 - License: it looks like that the source files and the COPYING file points to GPLv2+ instead of MIT - please can you check this? - package does not build (x86_64): Looking for required packages Checking for package 'mono-addins'.. found. Checking for package 'gtk-sharp-2.0'.. ERROR: Package named 'gtk-sharp-2.0' >= 2.12.8 not found. Try adjusting your PKG_CONFIG_PATH environment variable. error: Bad exit status from /var/tmp/rpm-tmp.d20ndr (%build) RPM build errors: - directory %{_libdir}/monodevelop/AddIns/JavaBinding must be packaged
SRPM URL: http://www.all-the-johnsons.co.uk/fedora/monodevelop-java-2.2-2.fc13.src.rpm SPEC : http://www.all-the-johnsons.co.uk/fedora/monodevelop-java.spec Fixes above issues
SRPM URL: http://www.all-the-johnsons.co.uk/fedora/monodevelop-java-2.2-3.fc13.src.rpm SPEC : http://www.all-the-johnsons.co.uk/fedora/monodevelop-java.spec Fixes the above and gettext issues
I've looked at the new package and I've observed the following issues: 1. This packages suffers from the same problem with the moved locales as monodevelop-boo: The translations are not found anymore at all. https://bugzilla.redhat.com/show_bug.cgi?id=551911#c5 2. There are a couple of minor rpmlint warnings (typos, tabs vs. spaces, ...) (no-binary, no-documentation, configure-... etc. are false positives, they don't need to be fixed) Please can you fix both of the problems before I do the full official review? Thanks!
I repackage monodevelop-java to update upstream version 2.4 Spec URL: http://elsupergomez.fedorapeople.org/SPECS/monodevelop-java.spec SRPM URL: http://elsupergomez.fedorapeople.org/SRPMS/monodevelop-java-2.4-1.fc13.src.rpm Please review FE-NEEDSPONSOR Thanks!
#7 : Is this based on my srpm?
(In reply to comment #8) > #7 : Is this based on my srpm? Yes!, is based on your srpm.
Paul, are you still interested getting this package reviewed? Claudio, if you want to take over this review, I think the best way would be if you create a new Review Request.
Ping? Any progress here? Or we can close this review?
Monodevelop from 3.0 and newer not provide a source for this plugin. I suggest to close ticket.
closing per #12