Bug 552253 - Merge Review: perl-Test-MockObject - Perl extension for emulating troublesome interfaces
Summary: Merge Review: perl-Test-MockObject - Perl extension for emulating troublesome...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-04 13:56 UTC by Marcela Mašláňová
Modified: 2010-08-27 19:06 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-04 07:50:21 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Marcela Mašláňová 2010-01-04 13:56:40 UTC
SRPM: http://mmaslano.fedorapeople.org/MergeReview/perl-Test-MockObject-1.09-4.fc13.src.rpm
Spec: http://mmaslano.fedorapeople.org/MergeReview/perl-Test-MockObject.spec
Description: 
Test::MockObject is a highly polymorphic testing object, capable of
looking like all sorts of objects.  This makes white-box testing much
easier, as you can concentrate on what the code being tested sends to
and receives from the mocked object, instead of worrying about faking
up your own data.  (Another option is not to test difficult things.
Now you have no excuse.)

Comment 1 Marcela Mašláňová 2010-01-08 15:57:16 UTC
Maybe we can use this old review
http://forums.fedoraforum.org/archive/index.php/t-18039.html

Comment 2 Parag AN(पराग) 2010-01-15 06:52:37 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1923050
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
65da2c1067184f31f906d6c12cd6870e740d8d44  Test-MockObject-1.09.tar.gz
+ package meets naming and packaging guidelines.
+ make test gave
All tests successful.
Files=9, Tests=216,  0 wallclock secs ( 0.05 usr  0.02 sys +  0.37 cusr  0.07 csys =  0.51 CPU)
+ Package perl-Test-MockObject-1.09-4.fc13.noarch  =>
Provides: perl(Test::MockObject) = 1.09 perl(Test::MockObject::Extends) = 1.09
Requires: perl(Devel::Peek) perl(Scalar::Util) perl(Test::Builder) perl(Test::MockObject) perl(UNIVERSAL::can) perl(UNIVERSAL::isa) perl(strict) perl(vars) perl(warnings)

Suggestions:
1) add following line
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'

2) change line
chmod -R u+w $RPM_BUILD_ROOT/*
to
%{_fixperms} $RPM_BUILD_ROOT/*

APPROVED.

Comment 3 Parag AN(पराग) 2010-02-04 05:09:01 UTC
ping

Comment 4 Marcela Mašláňová 2010-02-04 07:50:21 UTC
Thank you fixed in perl-Test-MockObject-1.09-5.fc13.src.rpm

Comment 5 Mark Chappell 2010-08-26 15:14:41 UTC
Package Change Request
======================
Package Name: perl-Test-MockObject
New Branches: EL-6
Owners: lkundrak tremble

perl-Test-MockObject is one of the many limited arch option packages in RHEL6.

lkundrak owns the EL5 branch

15:04 < tremble> lkundrak : Are you averse to an EL6 branch for perl-Test-MockObject - just needs a rebuild of the RH SRPM which is only available for some arches.  I'm happy to 
                 help maintain that branch
15:05 < lkundrak> tremble: I'm happy to grant you access in pkgdb then, if you don't have it already
15:05 < lkundrak> tremble: otherwise please request it
15:05 < tremble> lkundrak : It needs a branch request too, I'll drop one in.

Comment 6 Kevin Fenzi 2010-08-27 19:06:23 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.