Bug 552855 - Merge Review: anthy - Japanese character set input library
Summary: Merge Review: anthy - Japanese character set input library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-06 11:42 UTC by Akira TAGOH
Modified: 2014-10-27 11:58 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-29 07:17:38 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
anthy spec cleanup patch (8.04 KB, patch)
2010-09-07 10:38 UTC, Parag AN(पराग)
no flags Details | Diff

Description Akira TAGOH 2010-01-06 11:42:54 UTC
I'm not quite sure why we've missed the merge review for anthy but apparently it wasn't done. so I'm requesting to ensure making it better.

http://cvs.fedoraproject.org/viewvc/devel/anthy/

Comment 1 Parag AN(पराग) 2010-09-07 10:38:07 UTC
Created attachment 443478 [details]
anthy spec cleanup patch

To this patch please add changelog, release is already bumped.

Comment 2 Parag AN(पराग) 2010-09-07 10:41:20 UTC
1) Above Suggested are few new changes like buildroot,%clean and cleaning of buildroot in %install can be removed.
See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag and https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

2) Removed Obsoletes and Provides based on guideline-> http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F

3) only issue not addressed in above patch is
anthy.x86_64: W: non-conffile-in-etc /etc/anthy-conf

Comment 3 Parag AN(पराग) 2010-09-24 13:52:53 UTC
Ping

Comment 4 Akira TAGOH 2010-09-27 08:31:09 UTC
Thanks for the review and the patch. applied it, rebuilding:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2491135

Comment 5 Parag AN(पराग) 2010-09-29 07:17:38 UTC
Thanks. APPROVED.

Comment 6 Akira TAGOH 2014-10-27 02:12:51 UTC
Package Change Request
======================
Package Name: anthy
New Branches: epel7
Owners: tagoh
InitialCC: i18n-team

Comment 7 Gwyn Ciesla 2014-10-27 11:58:54 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.