Bug 552856 - PATCH: Recognize gphoto2 cameras which don't implement get storageinfo
Summary: PATCH: Recognize gphoto2 cameras which don't implement get storageinfo
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gvfs
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Tomáš Bžatek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-06 11:50 UTC by Hans de Goede
Modified: 2015-03-03 22:43 UTC (History)
4 users (show)

Fixed In Version: 1.4.3-2.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-14 01:26:09 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
PATCH: Recognize gphoto2 cameras which don't implement get storageinfo (1.40 KB, patch)
2010-01-06 11:50 UTC, Hans de Goede
no flags Details | Diff

Description Hans de Goede 2010-01-06 11:50:25 UTC
Created attachment 381964 [details]
PATCH: Recognize gphoto2 cameras which don't implement get storageinfo

Not all gphoto drivers implement get storage info (drivers for proprietary
protocols often don't). This patch fixes the gphoto2volumemonitor to still
recognize cams which gphoto driver does not implement get storage info.

Note that I have a Fedora pkg CVS gvfs/devel checkout with this patch and the patch for bug 552842 in place and integrated into the specfile. So it is very little effort for me to commit and build a new gvfs with this fixed for rawhide,
if you're ok with me doing that.

Just like bug 552842 this patch applies to Fedora 12 too, and would be nice to
have in an update there too.

I've also attached this patch to the already existing upstream bugreport:
https://bugzilla.gnome.org/show_bug.cgi?id=606059

Comment 1 Tomáš Bžatek 2010-01-06 16:34:44 UTC
So far it looks good to me (and logical), as well the patch in bug 552842. But I really want to keep David the last word here as he's gphoto2 master in gvfs.

Comment 2 Fedora Update System 2010-01-14 01:25:55 UTC
gvfs-1.4.3-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.