Created attachment 385857 [details] CS/IPA TIP RA/TPS registry changes for "base" These base 'diffs' apply to the following bugs: * Bugzilla Bug #512234 - Move pkiuser:pkiuser check from spec file into pkicreate . . . * Bugzilla Bug #547471 - Apply PKI SELinux changes to PKI registry model * Bugzilla Bug #553076 - Apply "registry" logic to pki-ra . . . * Bugzilla Bug #553078 - Apply "registry" logic to pki-tps . . .
Created attachment 385858 [details] CS/IPA TIP RA/TPS registry changes for "dogtag" These dogtag 'diffs' apply to the following bugs: * Bugzilla Bug #512234 - Move pkiuser:pkiuser check from spec file into pkicreate . . . * Bugzilla Bug #547471 - Apply PKI SELinux changes to PKI registry model * Bugzilla Bug #553076 - Apply "registry" logic to pki-ra . . . * Bugzilla Bug #553078 - Apply "registry" logic to pki-tps . . .
Created attachment 386041 [details] CS/IPA TIPS RA/TPS registry changes for "base" Per code review: pki.if: * removed the following lines from 'pki_tps_template': class dir search; class file read; class file open; * removed the following lines from 'pki_ra_template': class dir search; class file read; class file open; pkicommon: * in 'create_user' changed: system( "$command" ); * to: my $report = ""; ... $report = `$command`; if( $report ne "" ) { emit( "$report", "error" ); } * in 'create_group' changed: system( "$command" ); to: my $report = ""; ... $report = `$command`; if( $report ne "" ) { emit( "$report", "error" ); } pki-rad: * removed the following lines from 'reload_instance()': # overwrite output from "killproc" echo -n $"Stopping ${prog}: " * from 'reload()' changed: echo "BEGIN SHUTTING DOWN '${PKI_TYPE}' INSTANCE(S):" to: echo "BEGIN RELOADING '${PKI_TYPE}' INSTANCE(S):" pki-tpsd: * removed the following lines from 'reload_instance()': # overwrite output from "killproc" echo -n $"Stopping ${prog}: " * from 'reload()' changed: echo "BEGIN SHUTTING DOWN '${PKI_TYPE}' INSTANCE(S):" to: echo "BEGIN RELOADING '${PKI_TYPE}' INSTANCE(S):"
Created attachment 386042 [details] CS/IPA TIPS RA/TPS registry changes for "dogtag" Per code review: pki-setup.spec: * Made certain that ALL four bugs were referenced in the changelog. pki-selinux.spec: * Made certain that ALL four bugs were referenced in the changelog. pki-ra.spec: * Made certain that ALL four bugs were referenced in the changelog. pki-tps.spec: * Made certain that ALL four bugs were referenced in the changelog. * Changed 'strip' to '%{__strip}'
https://bugzilla.redhat.com/attachment.cgi?id=386029 +alee https://bugzilla.redhat.com/attachment.cgi?id=386035 +alee
# cd pki/base # svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^? M selinux/src/pki.if M selinux/src/pki.fc M selinux/src/pki.te M setup/pkicreate M setup/pkicommon D ra/setup/postinstall M ra/apache/conf/httpd.conf D ra/etc/init.d/httpd A ra/etc/init.d/pki-rad M ra/build.xml M tps/configure M tps/Makefile.in M tps/build.xml M tps/configure.ac M tps/setup_package M tps/apache/conf/httpd.conf D tps/setup/postinstall M tps/Makefile.am D tps/etc/init.d/httpd A tps/etc/init.d/pki-tpsd # svn commit Sending base/ra/apache/conf/httpd.conf Sending base/ra/build.xml Deleting base/ra/etc/init.d/httpd Adding base/ra/etc/init.d/pki-rad Deleting base/ra/setup/postinstall Sending base/selinux/src/pki.fc Sending base/selinux/src/pki.if Sending base/selinux/src/pki.te Sending base/setup/pkicommon Sending base/setup/pkicreate Sending base/tps/Makefile.am Sending base/tps/Makefile.in Sending base/tps/apache/conf/httpd.conf Sending base/tps/build.xml Sending base/tps/configure Sending base/tps/configure.ac Deleting base/tps/etc/init.d/httpd Adding base/tps/etc/init.d/pki-tpsd Deleting base/tps/setup/postinstall Sending base/tps/setup_package Transmitting file data ................ Committed revision 933. # cd pki/dogtag # svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^? M selinux/pki-selinux.spec M selinux/build_dogtag M setup/build_dogtag M setup/pki-setup.spec M ra/pki-ra.spec M tps/pki-tps.spec # svn commit Sending dogtag/ra/pki-ra.spec Sending dogtag/selinux/build_dogtag Sending dogtag/selinux/pki-selinux.spec Sending dogtag/setup/build_dogtag Sending dogtag/setup/pki-setup.spec Sending dogtag/tps/pki-tps.spec Transmitting file data ...... Committed revision 934.
Created attachment 387523 [details] "*.cgi" TPS registry changes for "base"
Created attachment 387524 [details] "*.cgi" TPS registry changes for "dogtag"
https://bugzilla.redhat.com/attachment.cgi?id=387524 alee+ https://bugzilla.redhat.com/attachment.cgi?id=387523 - The $entity variable is a temporary variable and should be locally - and not globally defined. In fact, you can define it within the while loop where it is used. while( defined( my $entity = readdir( SUBSYSTEM_DIR ) ) ) {
# cd pki/base # svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^? M setup/pkicreate M tps/forms/esc/cgi-bin/so/enroll.cgi M tps/forms/esc/cgi-bin/sow/seturl.cgi M tps/forms/esc/cgi-bin/sow/enroll_temp.cgi M tps/forms/esc/cgi-bin/sow/main.cgi M tps/forms/esc/cgi-bin/sow/format.cgi M tps/forms/esc/cgi-bin/sow/is_agent.cgi M tps/forms/esc/cgi-bin/sow/search_temp.cgi M tps/forms/esc/cgi-bin/sow/formatso.cgi M tps/forms/esc/cgi-bin/sow/enroll.cgi M tps/forms/esc/cgi-bin/sow/welcome.cgi M tps/forms/esc/cgi-bin/sow/ajax-list.cgi M tps/forms/esc/cgi-bin/sow/noaccess.cgi M tps/forms/esc/cgi-bin/sow/read_temp.cgi M tps/forms/esc/cgi-bin/sow/search.cgi M tps/forms/esc/cgi-bin/sow/index.cgi M tps/forms/esc/cgi-bin/sow/is_user.cgi M tps/forms/esc/cgi-bin/sow/read.cgi # svn commit Sending base/setup/pkicreate Sending base/tps/forms/esc/cgi-bin/so/enroll.cgi Sending base/tps/forms/esc/cgi-bin/sow/ajax-list.cgi Sending base/tps/forms/esc/cgi-bin/sow/enroll.cgi Sending base/tps/forms/esc/cgi-bin/sow/enroll_temp.cgi Sending base/tps/forms/esc/cgi-bin/sow/format.cgi Sending base/tps/forms/esc/cgi-bin/sow/formatso.cgi Sending base/tps/forms/esc/cgi-bin/sow/index.cgi Sending base/tps/forms/esc/cgi-bin/sow/is_agent.cgi Sending base/tps/forms/esc/cgi-bin/sow/is_user.cgi Sending base/tps/forms/esc/cgi-bin/sow/main.cgi Sending base/tps/forms/esc/cgi-bin/sow/noaccess.cgi Sending base/tps/forms/esc/cgi-bin/sow/read.cgi Sending base/tps/forms/esc/cgi-bin/sow/read_temp.cgi Sending base/tps/forms/esc/cgi-bin/sow/search.cgi Sending base/tps/forms/esc/cgi-bin/sow/search_temp.cgi Sending base/tps/forms/esc/cgi-bin/sow/seturl.cgi Sending base/tps/forms/esc/cgi-bin/sow/welcome.cgi Transmitting file data .................. Committed revision 956. # cd pki/dogtag # svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^? M setup/build_dogtag M setup/pki-setup.spec M tps/pki-tps.spec # svn commit Sending dogtag/setup/build_dogtag Sending dogtag/setup/pki-setup.spec Sending dogtag/tps/pki-tps.spec Transmitting file data ... Committed revision 957.
Created attachment 388145 [details] Response to Comment #6 in Bugzilla Bug #553852
https://bugzilla.redhat.com/attachment.cgi?id=388145 alee+
# cd pki/dogtag # svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^? M osutil/osutil.spec M symkey/pki-symkey.spec M native-tools/pki-native-tools.spec M common/pki-common.spec M setup/pki-setup.spec M ra/pki-ra.spec M tps/pki-tps.spec # svn commit Sending dogtag/common/pki-common.spec Sending dogtag/native-tools/pki-native-tools.spec Sending dogtag/osutil/osutil.spec Sending dogtag/ra/pki-ra.spec Sending dogtag/setup/pki-setup.spec Sending dogtag/symkey/pki-symkey.spec Sending dogtag/tps/pki-tps.spec Transmitting file data ....... Committed revision 964.
pki-setup-1.3.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-setup-1.3.3-2.fc11
pki-setup-1.3.3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-setup-1.3.3-2.fc12
pki-setup-1.3.3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
pki-setup-1.3.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.