Bug 553205 - Merge Review: perl-Error - Error/exception handling in an OO-ish way
Summary: Merge Review: perl-Error - Error/exception handling in an OO-ish way
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-07 12:15 UTC by Marcela Mašláňová
Modified: 2010-01-18 09:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-18 09:23:56 UTC
Type: ---
Embargoed:
iarnell: fedora-review+


Attachments (Terms of Use)

Description Marcela Mašláňová 2010-01-07 12:15:33 UTC
SRPM: http://kojipkgs.fedoraproject.org/packages/perl-Error/0.17015/4.fc13/src/perl-Error-0.17015-4.fc13.src.rpm
Spec: http://koji.fedoraproject.org/koji/fileinfo?rpmID=1712807&filename=perl-Error.spec
Description: The Error package provides two interfaces. Firstly Error provides a procedural interface to exception handling. Secondly Error is a base class for errors/exceptions that can either be thrown, for subsequent catch, or can simply be recorded.

Comment 1 Iain Arnell 2010-01-17 08:41:09 UTC
+ source files match upstream.  
  203bc410ae5040e7b647a52aa0fabafe  Error-0.17015.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
- latest version is being packaged.
  0.17016 is available

+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  https://koji.fedoraproject.org/koji/buildinfo?buildID=145298

+ package installs properly.
+ rpmlint has no complaints:
  perl-Error.noarch: I: checking
  perl-Error.src: I: checking
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
  perl(Error) = 0.17015
  perl(Error::Simple)
  perl(Error::WarnDie)
  perl(Error::subs)
  perl-Error = 1:0.17015-4.fc13
=
  perl >= 0:5.004
  perl(:MODULE_COMPAT_5.10.1)
  perl(Error)
  perl(Exporter)
  perl(Scalar::Util)
  perl(overload)
  perl(strict)
  perl(vars)
  perl(warnings)
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(PayloadIsXz) <= 5.2-1
  rpmlib(VersionedDependencies) <= 3.0.3-1

+ %check is present and all tests pass.
  All tests successful.
  Files=15, Tests=64,  1 wallclock secs ( 0.05 usr  0.02 sys +  0.49 cusr  0.19 csys =  0.75 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


APPROVED - only minor problem is that this isn't the latest upstream version - 0.17016 is available.


Note You need to log in before you can comment on or make changes to this bug.