Spec URL: http://thomasj.fedorapeople.org/reviews/luckybackup.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/luckybackup-0.3.3-1.fc11.src.rpm Description: luckyBackup is an application that backs-up and/or synchronizes any directories with the power of rsync. It is simple to use, fast (transfers over only changes made and not all data), safe (keeps your data safe by checking all declared directories before proceeding in any data manipulation ), reliable and fully customizable. [thomas@tusdell SPECS]$ rpmlint luckybackup.spec ../SRPMS/luckybackup-0.3.3-1.fc11.src.rpm ../RPMS/x86_64/luckybackup-* 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
I'd be happy to review this. Look for a full review later today.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv3+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: aa1f75133ca1f03d58c891843596eb36 luckybackup-0.3.3.tar.gz aa1f75133ca1f03d58c891843596eb36 luckybackup-0.3.3.tar.gz.orig OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. See below - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag See below - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Two of the desktop files here (the ones with -su in them) call: 'su-to-root'. Where is that provided? Should we just not ship those? Or change them to run a different way in Fedora? 2. 0.3.5 is out now. Can you update? 3. Does smp_mflags not work here? Might note that or add it to the make. 4. rpmlint says: luckybackup.i586: W: spelling-error-in-description en_US rsync luckybackup.i586: W: spelling-error-in-description en_US customizable luckybackup.src: W: spelling-error-in-description en_US rsync luckybackup.src: W: spelling-error-in-description en_US customizable Can be ignored. 5. Do you really need: Requires: qt-x11, qt It looks to me like the QT requirement is pulled in fine from the binary.
(In reply to comment #2) > Issues: > > 1. Two of the desktop files here (the ones with -su in them) call: > 'su-to-root'. Where is that provided? Should we just not ship those? > Or change them to run a different way in Fedora? I changed it completely. I use now consolehelper and run the application as root in general. > 2. 0.3.5 is out now. Can you update? Sure, sorry. missed it. Fixed. > 3. Does smp_mflags not work here? Might note that or add it to the make. I use smp_mflags. It's only qmake-qt4 that doesn't understand the %{_smp_mflags} macro. > 4. rpmlint says: > luckybackup.i586: W: spelling-error-in-description en_US rsync > luckybackup.i586: W: spelling-error-in-description en_US customizable > luckybackup.src: W: spelling-error-in-description en_US rsync > luckybackup.src: W: spelling-error-in-description en_US customizable > > Can be ignored. > > 5. Do you really need: > Requires: qt-x11, qt > It looks to me like the QT requirement is pulled in fine from the binary. Hah, you're right. Removed the Requires. But i had to add a requires for usermode, due to rpmlint. Not sure if it's really needed or if usermode/consolehelper is installed/used in any spin. http://thomasj.fedorapeople.org/reviews/luckybackup-0.3.5-1.fc12.src.rpm http://thomasj.fedorapeople.org/reviews/luckybackup.spec -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Sorry for the delay here. > > 1. Two of the desktop files here (the ones with -su in them) call: > > 'su-to-root'. Where is that provided? Should we just not ship those? > > Or change them to run a different way in Fedora? > > I changed it completely. I use now consolehelper and run the application as > root in general. ok. Sounds good. > > 2. 0.3.5 is out now. Can you update? > > Sure, sorry. missed it. Fixed. Thanks. > > 3. Does smp_mflags not work here? Might note that or add it to the make. > > I use smp_mflags. It's only qmake-qt4 that doesn't understand the > %{_smp_mflags} macro. ok. This package takes a while to build here. ;( > > 5. Do you really need: > > Requires: qt-x11, qt > > It looks to me like the QT requirement is pulled in fine from the binary. > > Hah, you're right. Removed the Requires. > But i had to add a requires for usermode, due to rpmlint. Not sure if it's > really needed or if usermode/consolehelper is installed/used in any spin. Yeah, it should be required I think. You should remember to add changelog and bump the release in reviews... easier to check and confirm what versions the submitter/reviewer have. ;) No biggie though. I don't see any further blockers, so this package is APPROVED.
Yeah, the long buildtime is due to a cc1plus weirdness/bug in F-12 and -rawhide. Hope it get fixed soon. Thanks for the review nirik :) New Package CVS Request ======================= Package Name: luckybackup Short Description: A powerful, fast and reliable backup and sync tool Owners: thomasj Branches: F-11 F-12 InitialCC: -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
CVS done (by process-cvs-requests.py).
luckybackup-0.3.5-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/luckybackup-0.3.5-1.fc12
luckybackup-0.3.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/luckybackup-0.3.5-1.fc11
luckybackup-0.3.5-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update luckybackup'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1037
luckybackup-0.3.5-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update luckybackup'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1078
luckybackup-0.3.5-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
luckybackup-0.3.5-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.