Spec URL: http://dionysos.fedorapeople.org/SPECS/kbackup.spec SRPM URL: http://dionysos.fedorapeople.org/SRPMS/kde-plasma-birthday-reminder-0.9.72-1.fc12.src.rpm Description: KBackup is a program that lets you back up any directories or files, whereby it uses an easy to use directory tree to select the things to back up. The program was designed to be very simple in its use so that it can be used by non-computer experts. The storage format is the well known TAR format, whereby the data is still stored in compressed format (bzip2 or gzip).
Wrong SRPMS.
The correct SRPM is: http://dionysos.fedorapeople.org/SRPMS/kbackup-0.6.3-1.fc12.src.rpm
Sorry... Thank Kevin.
Well, * Desktop file installation - "Application" in Categories is deprecated and should be removed. - By the way, as you already apply a patch for desktop file, I don't see any necessity to use "--add-category" or "--remove-category" and I think merging these options to the patch is much simpler. * Scriptlets - As this package installs XML file in %{_datadir}/mime/packages, please refer to https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo - GTK icon related scriptlets are updated. Please refer to: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
(In reply to comment #4) > Well, > > * Desktop file installation > - "Application" in Categories is deprecated and should be removed. OK, done. > - By the way, as you already apply a patch for desktop file, > I don't see any necessity to use "--add-category" or "--remove-category" > and I think merging these options to the patch is much simpler. In fact, I just made this patch three hours ago to add the X-DocPath entry because help wasn't listed in the khelpcenter and to reorganize a little this file without removing categories provided by upstream. So, if upstream accept my patch, I'll still need to use "--add-category" or "--remove-category" for future release, so, I wish to keep them if you agree. > * Scriptlets > - As this package installs XML file in %{_datadir}/mime/packages, > please refer to > https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo > > - GTK icon related scriptlets are updated. Please refer to: > https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache OK, done, thanks for the reminder. %changelog * Sat Jan 9 2010 Alain Portal <alain.portal[AT]univ-montp2[DOT]fr> 0.6.3-2 - Don't add Application category in desktop file - Add update-mime-database in scriptlets - Update gtk-update-icon-cache use in scriptlets - Add %%posttrans scriptlet News files: http://dionysos.fedorapeople.org/SPECS/kbackup.spec http://dionysos.fedorapeople.org/SRPMS/kbackup-0.6.3-2.fc12.src.rpm
One point. - Now we usually use %defattr(-,root,root,-) ------------------------------------------------------------ This package (kbackup) is APPROVED by mtasaka ------------------------------------------------------------
(In reply to comment #6) > One point. > - Now we usually use %defattr(-,root,root,-) OK, done. %changelog * Sun Jan 10 2010 Alain Portal <alain.portal[AT]univ-montp2[DOT]fr> 0.6.3-3 - Updated %%defattr macro News files: http://dionysos.fedorapeople.org/SPECS/kbackup.spec http://dionysos.fedorapeople.org/SRPMS/kbackup-0.6.3-3.fc12.src.rpm > ------------------------------------------------------------ > This package (kbackup) is APPROVED by mtasaka > ------------------------------------------------------------ Am I allowed to commit the package or do I have to wait something?
Oups... Thanks for the review ;-)
(In reply to comment #7) Please follow http://fedoraproject.org/wiki/New_package_process_for_existing_contributors from "Step 7" (i.e. first write CVS request as written in) http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Please mention in the CVS request that this package was once got orphaned and this is to reintroduce the existed package.
OK, thanks.
New Package CVS Request ======================= Package Name: kbackup Short Description: Back up your data in a simple, user friendly way Owners: dionysos Branches: F-11 F-12 InitialCC: This package was once got orphaned and this is to reintroduce the existed package.
This package already exists, so we can't do a "new package CVS request". What I've done is create the F-11 and F-12 branches. If there was something else you needed, please re-raise the fedora-cvs flag.
Closing (rebuild done for all branches, push request submitted on bodhi for F-12/11)
Package Change Request ====================== Package Name: kbackup New Branches: EL-6
cvs done.