Bug 553842 - Review Request: pki-kra - Dogtag Data Recovery Manager
Summary: Review Request: pki-kra - Dogtag Data Recovery Manager
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Dogtag-to-Fedora
TreeView+ depends on / blocked
 
Reported: 2010-01-09 04:10 UTC by Kevin Wright
Modified: 2015-07-13 04:56 UTC (History)
8 users (show)

Fixed In Version: 1.3.0-4.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-04 05:00:55 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kwright: fedora-cvs+


Attachments (Terms of Use)

Description Kevin Wright 2010-01-09 04:10:19 UTC
first pass at getting this built in fedora

Comment 1 Jason Tibbitts 2010-01-09 05:53:32 UTC
Be nice if you folks could use the standard template for review requests.  Of course, it would also be nice if you could wait until you actually have packages to submit before opening all these tickets.

Comment 2 Kevin Wright 2010-01-13 02:05:07 UTC
Spec URL: http://people.redhat.com/kwright/pki-kra/pki-kra.spec
SRPM URL: http://people.redhat.com/kwright/pki-kra/pki-kra-1.3.0-3.fc11.src.rpm

Description: Dogtag Data Recovery Manager

Comment 3 Kevin Wright 2010-01-16 00:48:41 UTC
Updated spec file and src rpm:

Spec URL: http://people.redhat.com/kwright/pki-kra/pki-kra.spec
SRPM URL: http://people.redhat.com/kwright/pki-kra/pki-kra-1.3.0-4.fc11.src.rpm

Comment 4 Parag AN(पराग) 2010-01-19 08:45:09 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1931059
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
d9b10e61707706e71e9a674f884c07fce39c8933  pki-kra-1.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ Initscripts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package pki-kra-1.3.0-4.fc13.noarch =>
Provides: mimehandler(application/vnd.mozilla.xul+xml) mimehandler(application/xhtml+xml) mimehandler(text/html) mimehandler(text/mml) mimehandler(text/xml)
Requires:java >= 1:1.6.0 pki-common pki-kra-ui pki-selinux pki-silent  

APPROVED.

Comment 5 Kevin Wright 2010-01-19 15:43:07 UTC
New Package CVS Request
=======================
Package Name: pki-krai
Short Description: The Dogtag PKI Data Recovery Authority
Owners: kwright
Branches: F-11, F-12, EL-5
InitialCC: ausil

Comment 6 Kevin Wright 2010-01-19 16:12:27 UTC
correction:

Package Name: pki-kra

Comment 7 Jason Tibbitts 2010-01-19 18:26:07 UTC
CVS done (by process-cvs-requests.py).

Comment 8 Kevin Wright 2010-01-19 21:52:19 UTC
the package name was created using the original request and not the subsequent correction I made. Need this to be corrected before I can run the koji builds.

Comment 9 Jason Tibbitts 2010-01-20 00:09:26 UTC
If only you had simply provided a complete corrected CVS request.  These are processed by script; it didn't manage to figure out what you wanted.

Please provide a complete corrected CVS request and I will process it.

Comment 10 Kevin Wright 2010-01-20 00:14:12 UTC
New Package CVS Request
=======================
Package Name: pki-kra
Short Description: The Dogtag PKI Data Recovery Authority
Owners: kwright
Branches: F-11, F-12, EL-5
InitialCC: ausil

Comment 11 Jason Tibbitts 2010-01-20 00:24:00 UTC
This should be taken care of now.

Comment 12 Kevin Wright 2010-01-20 00:28:35 UTC
Jason, Thanks for taking care of this. Sorry for the typo.

Comment 13 Kevin Wright 2010-01-20 00:43:45 UTC
Jason. Sorry, I'm not able to check out of cvs:

there is no repository /cvs/pkgs/rpms/pki-kra

Comment 14 Jason Tibbitts 2010-01-20 00:59:55 UTC
Works for me:

> cvs co pki-kra
cvs checkout: Updating pki-kra
U pki-kra/Makefile
cvs checkout: Updating pki-kra/EL-5
U pki-kra/EL-5/.cvsignore
U pki-kra/EL-5/Makefile
U pki-kra/EL-5/branch
U pki-kra/EL-5/sources
cvs checkout: Updating pki-kra/F-11
U pki-kra/F-11/.cvsignore
U pki-kra/F-11/Makefile
U pki-kra/F-11/branch
U pki-kra/F-11/sources
cvs checkout: Updating pki-kra/F-12
U pki-kra/F-12/.cvsignore
U pki-kra/F-12/Makefile
U pki-kra/F-12/branch
U pki-kra/F-12/sources
cvs checkout: Updating pki-kra/devel
U pki-kra/devel/.cvsignore
U pki-kra/devel/Makefile
U pki-kra/devel/sources
cvs checkout: Updating common
U common/Makefile
U common/Makefile.common
U common/branches
U common/cvs-import.sh

Not sure what else I can do here.

Comment 15 Kevin Wright 2010-01-20 01:20:14 UTC
Jason, I guess I should have just given it more time. It's working fine now. Now back to my builds. :-)

Comment 16 Kevin Wright 2010-01-20 01:28:33 UTC
Looks like I spoke too soon:
Checking out module: 'pki-kra'
Unpacking source package: pki-kra-1.3.0-4.fc11.src.rpm...
L pki-kra-1.3.0.tar.gz
A pki-kra.spec

Checking : pki-kra-1.3.0.tar.gz on https://cvs.fedoraproject.org/repo/pkgs/upload.cgi...
Module "pki-krai" does not exist!

Comment 17 Fedora Update System 2010-01-20 16:56:49 UTC
pki-kra-1.3.0-4.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pki-kra-1.3.0-4.fc11

Comment 18 Fedora Update System 2010-01-20 17:13:46 UTC
pki-kra-1.3.0-4.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pki-kra-1.3.0-4.fc12

Comment 19 Fedora Update System 2010-01-20 17:49:13 UTC
pki-kra-1.3.0-4.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/pki-kra-1.3.0-4.el5

Comment 20 Fedora Update System 2010-01-20 22:39:43 UTC
pki-kra-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-kra'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0099

Comment 21 Fedora Update System 2010-01-22 22:37:56 UTC
pki-kra-1.3.0-4.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-kra'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0923

Comment 22 Fedora Update System 2010-01-22 22:41:52 UTC
pki-kra-1.3.0-4.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-kra'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0959

Comment 23 Fedora Update System 2010-02-09 03:58:50 UTC
pki-kra-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2010-02-09 05:03:34 UTC
pki-kra-1.3.0-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2010-02-09 05:08:42 UTC
pki-kra-1.3.0-4.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.