Description of problem:
Bitmaps not to show in Windows installers created with makensis. Running the installer under wine reveals that the installers exe have a dll dependency:
err:module:import_dll Library libgcc_s_sjlj-1.dll (which is needed by L"C:\\windows\\temp\\nsw2ee.tmp\\System.dll") not found
(Although on Fedora, one can configure wine so this dll is actually found, windows users will typically not have this dll in their path when running the installer on their system.)
The dependency is easily removed by compiling the plugins with -static-libgcc. A patch is attached.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
cat > test.nsi <<EOF
!insertmacro MUI_LANGUAGE "English"
The installer bitmap is not visible on the welcome page.
The installer bitmap is visible on the welcome page.
Attached patch fixes the bug.
Created attachment 382700 [details]
compile plugins with -static-libgcc
The "if plugin_env['PLATFORM'] != 'win32':" part is not really necessary, the flag also makes sense for native MinGW builds, and besides we just patch the NSIS build system for what we want anyway.
This is an upstream bug, right?
Yes, I think so. We'll need to send them the patch, otherwise they're unlikely to notice as they use M$VC for their own binaries.
Ok, I will report this upstream.
For reference, here's the upstream bug report:
mingw32-nsis-2.45-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update mingw32-nsis'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0397
mingw32-nsis-2.45-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
mingw32-nsis-2.45-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
mingw32-nsis-2.46-1.el5 has been submitted as an update for Fedora EPEL 5.
mingw32-nsis-2.46-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.