Spec URL: http://www.timlank.com/pam_radius_auth/pam_radius_auth.spec SRPM URL: http://www.timlank.com/pam_radius_auth/pam_radius_auth-1.3.17-0.src.rpm Description: This is the PAM to RADIUS authentication module. It allows any PAM-capable machine to become a RADIUS client for authentication and accounting requests. You will need a RADIUS server to perform the actual authentication. This is my first package, and I am seeking a sponsor.
few notes: - the %global definition at the top are redundant, the same is achieved when the values are placed into Name, Version and Release tags - Release must be > 0 and incremented for each iteration when the version remains the same - value of License is not valid - see https://fedoraproject.org/wiki/Licensing for available values - %setup -q -n pam_radius_auth-%{version} is equivalent to simple %setup -q - ownership and permissions for /etc/raddb/server should be set in %files section with "%attr(root,root, 0600) %config()..." - the /etc/raddb directory must be owned by the package (%dir %{_sysconfdir}/raddb) and then it is properly removed on uninstall - use %{_sysconfigdir} instead of /etc - you can learn from some other pam module available at http://cvs.fedoraproject.org/viewvc/rpms/
*** Bug 554087 has been marked as a duplicate of this bug. ***
*** Bug 554085 has been marked as a duplicate of this bug. ***
updated .spec file to apply changes recommended by Dan new .spec and .src.rpm at location in original post
More issues: - /etc/raddb is already owned by freeradius package. - CFLAGS must be %{optflags}
The ownership of /etc/raddb directory opens more questions - for example: does this pam modules work with any radius server or only with freeradius? If the config file is used exclusively by this pam module, why is it not installed directly in /etc? For details about file and directory ownership please read https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
closing this review request. Starting over with a new request.