Spec URL: http://sites.google.com/site/pankaj86/files/fgrun.spec SRPM URL: http://sites.google.com/site/pankaj86/files/fgrun-1.5.1-1.src.rpm Description: FlightGear Launch Control is a graphical frontend for launching FlightGear flight simulator, <http://www.flightgear.org/>. It is the default official flightgear launcher on windows platform (comes bundled with the windows installer) This is my first package. I need a sponsored packager for this. Made the spec more than a year ago, but hesitated to submit till now. I've checked it builds in mock in F12 x86_64.
Have you verified it actually works? I've made a spec for it as well, but couldn't get it going. Here, both 1.5.1 and current trunk have a very obvious bug: the airportlist is empty. I'm on x86 here. This is the (only) reason I haven't put it up for review yet. Stefan
Yes i did run it, and it works for me well here. Actually on the first run I have to set the executable as "/usr/bin/fgfs" and FG_ROOT as "/usr/share/FlightGear" in the first run screen (This can be avoided if needed by installing a wrapper to set the appropriate env variables before running fgrun, i got the idea from pclos spec). And then it works for me, including showing the airports. I'm on F12 x86_64, if that makes a difference i'm not sure. Can you try and check if it works for you.
Just some quick comments on your spec file. - The dist tag is missing. https://fedoraproject.org/wiki/Packaging:DistTag - The license is GPLv2+, check source file header ...(at your option) any later version. - Add %{?_smp_mflags} to make https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - If this is a GUI application, a .desktop file is needed https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - Isn't 'make install' missing in the %install section. There is only another make. - Aren't your requirements (fltk, SimGear, sg3_utils) automatically picked by RPM? -
Thanks for your valuable inputs Fabian. > - The dist tag is missing. > https://fedoraproject.org/wiki/Packaging:DistTag I did check the page and put the DistTag once in the spec once and then saw that it generated .fc12 srpm, which i did not like so i had removed the DistTag since it wasn't mandatory. I have put it back again. > - The license is GPLv2+, check source file header ...(at your option) any later > version. Changed > - Add %{?_smp_mflags} to make > https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make Added, thanks. > - If this is a GUI application, a .desktop file is needed > https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files I've added this one (though there's no icon yet for fgrun), with some help from pclos srpm. Is there any way to verify if it is working properly. > - Isn't 'make install' missing in the %install section. There is only another > make. Corrected. That was probably a typo. > - Aren't your requirements (fltk, SimGear, sg3_utils) automatically picked by > RPM? Changed (removed few requires). RPM does indeed pick up the required linked libraries as dependencies. Thanks. New version : Spec file : http://sites.google.com/site/pankaj86/files/fgrun.spec?revision=9 SRPM file : http://sites.google.com/site/pankaj86/files/fgrun-1.5.1-1.fc12.src.rpm?revision=4 @ Stefan Riemens Comment#1 It'd be great if you can check the package if it shows the airports list on x86. Also it'd be great if you could post your spec so that i may also try it on my x86_64 and see what the problem may be. Thanks
Created attachment 396765 [details] replace fltk wrapper around scandir() I need this patch so fgrun properly scans flightgear scenery subdirs for airports. Does it work for you too ?
Actually my fgrun works (shows all the airports) without any patching. So i'm not sure how do i test it. Also I've tried using koji for scratch build sometime back but it doesn't work behind my university proxy. Also lot of my project work is remaining so i'm not sure i'll be able to maintain the package. Hence if any of you wants to take the ownership of the package then i'll be glad. I'm trying to test out the package but not sure if i'll be able to handle maintainership. Thanks a lot
I'm okay to take ownership of this package, if you agree.
That would be great. I suppose that would also mean removing the FE-NEEDSPONSOR tag. Any idea about the airports list problem. I tried it again by removing my ~/.fltk directory, and fgrun could gather all the airports data. I do remember there was a problem in my previous fedora version. What version are you on? Thanks again for taking it up. I'd love to get it added in fedora repo.
ok, I think I found the cause of the problem. fltk is build with -D_FILE_OFFSET_BITS=64, so fgrun must also be compiled with this same define, so the dirent struct has the same size in both fltk and in fgrun code, when browsing directory content.
I updated the package: - added -D_FILE_OFFSET_BITS=64 to the CXXFLAGS - added an icon taken from commons.wikimedia.org - added the opengl wrapper, that checks if direct rendering is available http://people.fedoraproject.org/~bellet/fgrun.spec http://people.fedoraproject.org/~bellet/fgrun-1.5.2-4.fc13.src.rpm
Fabrice, If I understand correctly you've taken over from Pankaj as the submitter of this package? If correct then please remove the FE-NEEDSPONSOR blocker, and let me know then I'll review the package for you :) Regards, Hans
Is anyone (besides Hans and I) listening?
I'm unable to package for fedora as the some tools (koji) don't work behind proxy (c#6). I thought Fabrice may take it up, but since it was quite long back i'm not sure if he's still around. If thats the case then i think the review request may need to be dropped. I'll be glad if there's anything i can do.
It's fine for me to be the submitter of this package. I'll check if the package from c#10 still works with current rawhide, and I'll propose an updated version for review ASAP. Thanks.
The package from comment #10 applies to rawhide without changes: http://people.fedoraproject.org/~bellet/fgrun.spec http://people.fedoraproject.org/~bellet/fgrun-1.5.2-4.fc15.src.rpm
Hi, Full review done: Good: - rpmlint checks return: fgrun.x86_64: W: dangling-relative-symlink /usr/bin/fgrun-wrapper opengl-game-wrapper.sh fgrun.x86_64: W: no-manual-page-for-binary fgrun fgrun.x86_64: W: no-manual-page-for-binary fgrun-wrapper 3 packages and 0 specfiles checked; 0 errors, 3 warnings. These can all be ignored. - package meets naming guidelines - license (GPLv2+ and CC-BY-SA) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file as needed and correctly installed Needs work: - Is missing a "Requires: hicolor-icon-theme" (for /usr/share/icons/hicolor dir hierarchy ownership). - Icon cache update scripts are of the old variant, see: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache For the new style - .desktop file: - contains obsolete: "Encoding=UTF-8" (remove please) - "Icon=fgrun.png" should be "Icon=fgrun", esp. as the package also ships an svg - %files contains: "%defattr(-,root,root)" please use "%defattr(-,root,root.-)" instead Regards, Hans
Hi Hans! Thanks a lot for the review. Here is the updated package with the requested modifications: http://people.fedoraproject.org/~bellet/fgrun.spec http://people.fedoraproject.org/~bellet/fgrun-1.5.2-5.fc15.src.rpm
Looks good now, approved!
New Package SCM Request ======================= Package Name: fgrun Short Description: Graphical front-end for launching FlightGear flight simulator Owners: bellet Branches: f13 f14 el4 el5 el6 InitialCC:
Git done (by process-git-requests).
Successfully built for rawhide, f14 and f13. Thanks!