Bug 554230 - No translated text replacement when <para> tag has attribute "revision"
Summary: No translated text replacement when <para> tag has attribute "revision"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: 1.6
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jeff Fearn 🐞
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-11 01:41 UTC by Richard Wilding
Modified: 2010-11-24 04:16 UTC (History)
5 users (show)

Fixed In Version: 1.4-1.fc12
Clone Of:
Environment:
Last Closed: 2010-02-01 01:14:48 UTC
Embargoed:


Attachments (Terms of Use)
Sample of proposed change (103.78 KB, image/png)
2010-01-19 01:44 UTC, Jeff Fearn 🐞
no flags Details

Description Richard Wilding 2010-01-11 01:41:57 UTC
Problem occurs when building translations.
Translated text is not replacing en-US text when the <para> tag has a revision attribute.
Example: <para revision="1">

This is valid under the Docbook spec:
http://www.sagehill.net/docbookxsl/RevisionControl.html

Version-Release number of selected component (if applicable): Fedora 11


How reproducible: always

Comment 1 Jeff Fearn 🐞 2010-01-19 01:44:01 UTC
Created attachment 385295 [details]
Sample of proposed change

Hi Richard, the current code sets the width to 60 and will be pushed out from there for individual lines greater than 60. Thus you will get a staggered layout if lines are variably above 60.

I'm thinking of changing this to make the default width 40, but if any line is greater than 36 it will change to maximum line with + 4.

This isn't full support for LineColumn, but it's something that I can get in the next version. Full support for LineColumn will take longer to implement.

Cheers, Jeff.

Comment 2 Jeff Fearn 🐞 2010-01-19 02:18:13 UTC
oops, wrong bug obviously :(

Comment 3 Jeff Fearn 🐞 2010-01-20 02:10:16 UTC
The text generated by the XML parser generates extra text if a tag contains attributes, this caused the string match to fail. Since the attribute content can not be stored in the PO file, and it probably wouldn't be useful for translation work flow anyway, I removed the attributes from the comparison string.

Note that the attributes will be present in the translated XML and thus will affect the XSLT operations as expected.

Comment 4 Fedora Update System 2010-01-29 02:05:24 UTC
publican-1.4-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/publican-1.4-1.fc12

Comment 5 Fedora Update System 2010-01-29 02:06:42 UTC
publican-1.4-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/publican-1.4-1.fc11

Comment 6 Fedora Update System 2010-02-01 01:13:31 UTC
publican-1.4-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2010-02-01 01:21:53 UTC
publican-1.4-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.