Bug 554260 - Review Request: ibus-table-xingma - The structure tables for IBus-Table
Summary: Review Request: ibus-table-xingma - The structure tables for IBus-Table
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Ding-Yi Chen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-11 06:54 UTC by caius.chance
Modified: 2010-03-11 13:33 UTC (History)
7 users (show)

Fixed In Version: ibus-table-xingma-1.2.0.20100305-2.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-11 13:33:40 UTC
dchen: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)
Patch to ibus-table-xingma (1.11 KB, text/plain)
2010-03-04 03:30 UTC, Ding-Yi Chen
no flags Details

Description caius.chance 2010-01-11 06:54:29 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 1 caius.chance 2010-01-11 06:57:03 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111-1.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 2 Naveen Kumar 2010-02-17 12:11:57 UTC
Here's an unofficial review, using the checklist from: http://fedoraproject.org/wiki/User:Tibbs/Review_Template

- source files do not match upstream: Could not retrieve files from upstream, specified in specfile, to do checksum
Other checksum output from srpm sources were:
163844d682a24c334752749e2fbb445f9b403a2c56a66f261b3d4c4ca292c478  :ibus-table-xingma-1.2.0.20100111.tar.gz
74ef342db7795af6552da53a0f57927f6f5a47b9243df6ba77f4edad0b43eb0c  :ibus-table-xingma.spec

  
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.
     license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
- Koji Build failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=1992777
- rpmlint is not silent. (rpmlint version 0.91)

rpmlint OUTPUT on src rpm:
ibus-table-xingma.src: E: description-line-too-long The structure tables for IBus Table, namely Wu, Yong, ZhuYin, ZhuYin Big, ZiRanMa.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

rpmlint OUTPUT on rpm:
ibus-table-xingma.noarch: E: description-line-too-long The structure tables for IBus Table, namely Wu, Yong, ZhuYin, ZhuYin Big, ZiRanMa.
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-stroke5
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-wubi
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-xinhua
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-zhengma
1 packages and 0 specfiles checked; 1 errors, 4 warnings.


* final provides and requires output:
   rpm -qp --provides output:  
ibus-table-xingma = 1.2.0.20100111-1.fc12

   rpm -qp --requires output: 
/bin/sh  
ibus >= 1.2
ibus >= 1.2
ibus-table >= 1.2.0.20100111
ibus-table >= 1.2.0.20100111
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rpmlib(PayloadIsXz) <= 5.2-1


+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ scriptlets sane
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.

Comment 3 Caius Chance 2010-02-23 04:55:59 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111-2.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 4 Caius Chance 2010-03-01 03:45:58 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111-3.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 5 Ding-Yi Chen 2010-03-04 00:20:39 UTC
I cannot download the source tarball, mind checking it?

Comment 6 Caius Chance 2010-03-04 00:57:20 UTC
fixed url of tarball

Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111-3.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 7 Ding-Yi Chen 2010-03-04 03:30:59 UTC
Created attachment 397710 [details]
Patch to ibus-table-xingma

Patch to ibus-table-xingma

Comment 8 Ding-Yi Chen 2010-03-04 03:33:43 UTC
rpmlint output:

ibus-table-xingma.src: W: spelling-error Summary(en_US) struct -> strict, strut, struck
ibus-table-xingma.src:19: W: unversioned-explicit-provides ibus-table-stroke5
ibus-table-xingma.src:19: W: unversioned-explicit-provides ibus-table-wubi
ibus-table-xingma.src:19: W: unversioned-explicit-provides ibus-table-xinhua
ibus-table-xingma.src:19: W: unversioned-explicit-provides ibus-table-zhengma
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

ibus-table-xingma.noarch: W: spelling-error Summary(en_US) struct -> strict, strut, struck
ibus-table-xingma.noarch: W: incoherent-version-in-changelog 1.2.0.20100111-3.fc13 ['1.2.0.20100111-3.fc12', '1.2.0.20100111-3']
ibus-table-xingma.noarch: W: self-obsoletion ibus-table-stroke5 <= 1.2.0.20100111 obsoletes ibus-table-stroke5
ibus-table-xingma.noarch: W: self-obsoletion ibus-table-wubi <= 1.2.0.20100111 obsoletes ibus-table-wubi
ibus-table-xingma.noarch: W: self-obsoletion ibus-table-xinhua <= 1.2.0.20100111 obsoletes ibus-table-xinhua
ibus-table-xingma.noarch: W: self-obsoletion ibus-table-zhengma <= 1.2.0.20100111 obsoletes ibus-table-zhengma
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

Things to fix:
1. Spelling error in summary
2. I've provides a patch to fix the provide/obsolete error.
3. Remove dist tag in changelog

Otherwise looks fine to me.

Comment 9 Caius Chance 2010-03-04 05:06:52 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111-4.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 10 Caius Chance 2010-03-04 05:32:03 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111-5.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 11 Ding-Yi Chen 2010-03-04 06:40:32 UTC
MUST:
+  rpmlint output is acceptable.
+  Package meets naming and packaging guidelines.
+  Package meets licensing guidelines, and match the source license.
+  Source files match upstream.
+  specfile is properly named, is cleanly written
+  Spec file is written in American English.
+  Spec file is legible.
+  dist tag is present.
+ BuildRoot is proper.
+  BuildRequires are proper.
+  Requires are proper.
+  %install starts with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
+  %clean contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
+  locale is handle by %find_lang.
+  %doc files present.
+  %doc files do not interfere runtime application.
+  Macros are consistently used.
+  ldconfig in %post and %postun if shared libraries are installed in default paths.
+  Package builds in koji.
+  Package contains code or permissible content.
+  Package installed properly.
+  No system library is bundled.
+  Not relocatable, unless proper justification is presented.
+  %files section must include a %defattr(...) line, and file permissions are correct.
+  No duplication in %files
+  File names are in valid UTF-8.
+  Own all directory it creates.
+  Files or directories are not owned by other packages.
+  No .la libtool archives exists.

SHOULD:
+  License text are in separate files.
+  Translations for supported non-English languages if available.
+  Package build in mock.
+  Package can build in all supported architectures.
+  Package runs properly.
+  Scriptlets are sane.
+  No direct files dependencies, unless they are in either /etc, /bin, /sbin, /usr/bin, or /usr/sbin

APPROVED

Comment 12 Caius Chance 2010-03-04 07:20:09 UTC
New Package CVS Request
=======================
Package Name: ibus-tables-xingma
Short Description: The structural tables for IBus-Table 
Owners: kaio
Branches: F-13
InitialCC: i18n-team

Comment 13 Caius Chance 2010-03-05 06:31:04 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100111-6.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 14 Caius Chance 2010-03-05 06:47:14 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100305-1.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 15 Caius Chance 2010-03-05 07:27:15 UTC
Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-xingma.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-xingma-1.2.0.20100305-2.fc12.src.rpm
Description: The structure tables for IBus-Table

Comment 16 Kevin Fenzi 2010-03-06 05:13:34 UTC
Your request has ibus-tables-xingma but shouldn't the package name be ibus-table-xingma 
(without the 's')?

Please check and reset the cvs flag.

Comment 17 Caius Chance 2010-03-06 14:54:59 UTC
New Package CVS Request
=======================
Package Name: ibus-table-xingma
Short Description: The structural tables for IBus-Table 
Owners: kaio
Branches: F-13
InitialCC: i18n-team    

sorry my mistake

Comment 18 Jason Tibbitts 2010-03-06 16:27:44 UTC
This ticket is not assigned to anyone.  I'll fix that up, but please remember to assign tickets to yourself when you review them.

Comment 19 Jason Tibbitts 2010-03-06 16:28:15 UTC
CVS done (by process-cvs-requests.py).

Comment 20 Fedora Update System 2010-03-08 02:16:30 UTC
ibus-table-xingma-1.2.0.20100305-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/ibus-table-xingma-1.2.0.20100305-2.fc13

Comment 21 Fedora Update System 2010-03-09 03:11:32 UTC
ibus-table-xingma-1.2.0.20100305-2.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ibus-table-xingma'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ibus-table-xingma-1.2.0.20100305-2.fc13

Comment 22 Fedora Update System 2010-03-11 13:33:33 UTC
ibus-table-xingma-1.2.0.20100305-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.