(FYI: Currently fedorapeople is down.) Spec URL: http://tomspur.fedorapeople.org/review/mozilla-noscript.spec SRPM URL: http://tomspur.fedorapeople.org/review/mozilla-noscript-1.9.9.35-1.fc12.src.rpm Description: The NoScript Firefox extension provides extra protection for Firefox. It allows JavaScript, Java, Flash and other plugins to be executed only by trusted web sites of your choice (e.g. your online bank) and additionally provides Anti-XSS protection. ###########################y rpmlint clean: $ rpmlint mozilla-noscript-1.9.9.35-1.fc12.src.rpm noarch/mozilla-noscript-1.9.9.35-1.fc12.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. ############################ builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1923507
*** Bug 512608 has been marked as a duplicate of this bug. ***
Spec URL: http://tomspur.fedorapeople.org/review/mozilla-noscript.spec SRPM URL: http://tomspur.fedorapeople.org/review/mozilla-noscript-1.9.9.35-2.fc12.src.rpm %changelog - remove R: firefox, this plugin also works for seamonky and so on it's up to the user, what to use Thanks Thomas Moschny. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1923974
Spec URL: http://tomspur.fedorapeople.org/review/mozilla-noscript.spec SRPM URL: http://tomspur.fedorapeople.org/review/mozilla-noscript-1.9.9.35-3.fc12.src.rpm %changelog - also install seamonkey app_id Thanks Thomas Moschny again :) Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1924075
OK - MUST: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/mozilla-noscript-1.9.9.35-3.fc13.* mozilla-noscript.noarch: W: uncompressed-zip /usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{73a6fe31-595d-460b-a920-fcc0f8843232}/chrome/noscript.jar 2 packages and 0 specfiles checked; 0 errors, 1 warnings. This is save to ignore. OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines OK - MUST: Fedora approved license and meets the Licensing Guidelines: GPLv2+ OK - MUST: License field in spec file matches the actual license OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 28f8cea89c3155c48ccf81bb9132ea5c OK - MUST: successfully compiles and builds into binary rpms on x86_64 OK - MUST: No ExcludeArch OK - MUST: all build dependencies are listed in BuildRequires N/A - MUST: handles locales properly with %find_lang N/A - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. OK - MUST: owns all directories that it creates OK - MUST: no duplicate files in the %files listing OK - MUST: Permissions on files are set properly, includes %defattr(...) OK - MUST: package has a %clean section, which contains rm -rf %{buildroot}. OK - MUST: consistently uses macros OK - MUST: package contains code, or permissable content N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application N/A - MUST: Header files must be in a -devel package N/A - MUST: Static libraries must be in a -static package N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A - MUST: If a package contains library files with a suffix, then library files that end in .so must go in a -devel package. N/A - MUST: devel packages must require the base package using a fully versioned dependency OK - MUST: The package does not contain any .la libtool archives. N/A - MUST: Packages containing GUI applications must include a %{name}.desktop file OK - MUST: package does not own files or directories already owned by other packages. OK - MUST: at the beginning of %install, the package runs rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK - SHOULD: builds in mock. OK - SHOULD: compiles and builds into binary rpms on all supported architectures. OK - SHOULD: functions as described. N/A - SHOULD: Scriptlets are used, those scriptlets must be sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg N/A - SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Other items: OK - latest stable version OK - SourceURL valid Minor: - Add -p to install in order to preserve timestamps. - Use the full length of 89 charakters in %description APPROVED
Thanks for the review. %changelog - install with -p Spec URL: http://tomspur.fedorapeople.org/review/mozilla-noscript.spec SRPM URL: http://tomspur.fedorapeople.org/review/mozilla-noscript-1.9.9.35-4.fc12.src.rpm ################################################ New Package CVS Request ======================= Package Name: mozilla-noscript Short Description: Javascript whitelist extension for Mozilla Firefox Owners: tomspur ixs Branches: F-11 F-12 InitialCC:
New Package CVS Request ======================= Package Name: mozilla-noscript Short Description: Javascript whitelist extension for Mozilla Firefox Owners: tomspur ixs Branches: F-11 F-12 EL-5 InitialCC:
CVS done (by process-cvs-requests.py).
mozilla-noscript-1.9.9.35-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mozilla-noscript-1.9.9.35-4.fc12
mozilla-noscript-1.9.9.35-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/mozilla-noscript-1.9.9.35-4.el5
mozilla-noscript-1.9.9.35-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mozilla-noscript-1.9.9.35-4.fc11
mozilla-noscript-1.9.9.35-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
mozilla-noscript-1.9.9.35-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
mozilla-noscript-1.9.9.35-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.