Spec URL: http://fedorapeople.org/~iarnell/review/perl-Email-Sender.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Email-Sender-0.100110-1.fc13.src.rpm Description: Email::Sender replaces the old and sometimes problematic Email::Send library, which did a decent job at handling very simple email sending tasks, but was not suitable for serious use, for a variety of reasons. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1925812 *rt-0.10
- = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: F12.x86_64 [x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings. [x] Package is not relocatable. [x] Buildroot is correct %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 6d3366cda79d469a87eaf4865138048d Email-Sender-0.100110.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=1927887 [-] Package should compile and build into binary rpms on all supported architectures. [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=18, Tests=278, 8 wallclock secs ( 0.09 usr 0.03 sys + 8.35 cusr 0.29 csys = 8.76 CPU) Result: PASS APPROVED
Thanks for the review. New Package CVS Request ======================= Package Name: perl-Email-Sender Short Description: A library for sending email Owners: iarnell Branches: F-12 InitialCC: perl-sig
CVS done (by process-cvs-requests.py).
committed and built in devel; waiting for perl-Sys-Hostname-Long and perl-Throwable on F-12 branch.
perl-Email-Sender-0.100110-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Email-Sender-0.100110-1.fc12
perl-Email-Sender-0.100110-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Email-Sender'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1410
perl-Email-Sender-0.100110-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
I've been asked in bug #1241821 to make this package available for EPEL-7. Package Change Request ====================== Package Name: perl-Email-Sender New Branches: epel7 Owners: eseyman InitialCC: perl-sig
Git done (by process-git-requests).