Bug 556074 - libsndfile : does not adhere to Static Library Packaging Guidelines
Summary: libsndfile : does not adhere to Static Library Packaging Guidelines
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libsndfile
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Orcan Ogetbil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-16 14:46 UTC by Michael Schwendt
Modified: 2010-05-11 15:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-05-11 14:56:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michael Schwendt 2010-01-16 14:46:51 UTC
The package is in need of an update because it does not adhere to
the guidelines for packaging static libraries:

  http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

The -devel package contains both the shared and the static build of
a library. That makes it possible to link statically with the -devel
package as a build requirement instead of having to build-require a
special-purpose -static subpackage.

Correct would be to either disable/delete the static libraries at
build-time, or to %exclude them in the %files section, or to split off
a -static subpackage (if there is a compelling reason as why the static
libs should be made available).

Please consult the guidelines for the details.

[...]

libsndfile-devel
    /usr/lib/libsndfile.so  <=>  /usr/lib/libsndfile.a

Comment 1 Michael Schwendt 2010-02-18 12:53:36 UTC
The packages that _directly_ BuildRequires libsndfile-devel, but don't produce a build that depends on the libsndfile SONAME:

  alure-1.0-4.fc13.src.rpm
  bluez-4.61-1.fc13.src.rpm
  muse-1.0.1-1.fc13.src.rpm

Checking those,

$ koji-build-log-check.py libsndfile-no-dso 
[...]
muse : links
moc_transpose.o moc_miditransform.o moc_appearance.o  -L/usr/lib/qt-3.3/lib -lqt-mt -lqui -lasound -lsndfile   -lsamplerate   -ljack -lpthread -lrt   -lpthread -ldl -lutil -lm -lpython2.6 remote/libre
$

only "muse" links with libsndfile but kills the automatic SONAME deps (bug 566419):

$ ldd /usr/bin/muse|grep snd
        libsndfile.so.1 => /usr/lib/libsndfile.so.1 (0x07470000)
$

Comment 2 Michael Schwendt 2010-03-11 19:47:47 UTC
From 45 src.rpms in Rawhide, which build with libsndfile-devel, only "swami" mentions "-static" or the static libsndfile library, albeit unrelated to libsndfile.

Comment 3 Bug Zapper 2010-03-15 14:03:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 13 development cycle.
Changing version to '13'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Orcan Ogetbil 2010-05-05 01:39:18 UTC
The libsndfile maintainer has been unresponsive for a while now. I did the last update (before this bug was filed). I wish I was more careful about the static lib.

I'll take care of this next week or so. libsndfile needs an update to new version anyway. I think it is too late for F-13 now to fix this, isn't it?

Comment 5 Orcan Ogetbil 2010-05-05 03:28:46 UTC
I don't think any of these packages were built against libsndfile with static linkage. alure and bluez don't even seem to need BR: libsndfile.

Should I just remove the static library? Do we need to make an announcement?

Comment 6 Michael Schwendt 2010-05-07 10:23:34 UTC
What would you want to announce? That you're going to remove something that nobody depends on? (not even unknowingly)

http://fedoraproject.org/wiki/Packaging:Guidelines#Staticly_Linking_Executables

Comment 7 Orcan Ogetbil 2010-05-07 18:28:32 UTC
Yeah.

or at least, that we didn't find any package linkage to the static libsndfile. Since it is a pretty much standard library, people could be using the static library for their own application. 

I don't know... that's why I asked.

Comment 8 Orcan Ogetbil 2010-05-11 14:56:53 UTC
Fixed in rawhide (F-14):
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2180479
Closing the bug.

Comment 9 Orcan Ogetbil 2010-05-11 15:00:54 UTC
By 'fixed', I mean the static library is removed from the package.


Note You need to log in before you can comment on or make changes to this bug.