Bug 556096 - sysfsutils : does not adhere to Static Library Packaging Guidelines
Summary: sysfsutils : does not adhere to Static Library Packaging Guidelines
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: sysfsutils
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Anton Arapov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 605546
TreeView+ depends on / blocked
 
Reported: 2010-01-16 14:47 UTC by Michael Schwendt
Modified: 2014-06-18 08:02 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
: 605546 (view as bug list)
Environment:
Last Closed: 2010-06-18 08:43:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
move the libs (1.30 KB, patch)
2010-06-17 13:13 UTC, Anton Arapov
no flags Details | Diff

Description Michael Schwendt 2010-01-16 14:47:43 UTC
The package is in need of an update because it does not adhere to
the guidelines for packaging static libraries:

  http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

The -devel package contains both the shared and the static build of
a library. That makes it possible to link statically with the -devel
package as a build requirement instead of having to build-require a
special-purpose -static subpackage.

Correct would be to either disable/delete the static libraries at
build-time, or to %exclude them in the %files section, or to split off
a -static subpackage (if there is a compelling reason as why the static
libs should be made available).

Please consult the guidelines for the details.

[...]

libsysfs-devel
    /usr/lib/libsysfs.so  <=>  /usr/lib/libsysfs.a

Comment 1 Anton Arapov 2010-01-18 10:37:04 UTC
Thanks for noticing! It seems we don't need statically linked lib at all... I can't see the reason at the moment... Will push the change to the tree asap.

Comment 2 Anton Arapov 2010-01-18 10:40:27 UTC
in 2.1.0-7.fc13

Comment 3 Harald Hoyer 2010-06-17 10:47:24 UTC
pcmciautils needs either a static libsysfs or the libs should be moved out of /usr to /lib*, because the tools run at startup, where /usr might not be accessible yet.

Comment 4 Harald Hoyer 2010-06-17 10:47:52 UTC
Currently we cannot even rebuild pcmciautils.

Comment 5 Harald Hoyer 2010-06-17 10:55:25 UTC
(In reply to comment #4)
> Currently we cannot even rebuild pcmciautils.    

scratch that comment.

Comment 6 Anton Arapov 2010-06-17 11:06:26 UTC
(In reply to comment #5)
and does pcmciautils still needs static libsysfs?

Comment 7 Harald Hoyer 2010-06-17 11:13:01 UTC
as I said.. if the libs were in /lib* it would not need the static libs.

F-13/devel currently builds with the dynamic libs, but that was just a workaround.
RHEL-6 still needs the static libs.

Comment 8 Anton Arapov 2010-06-17 13:13:01 UTC
Created attachment 424808 [details]
move the libs

  since there is a *real* demand to have the libs during the boot, it is possible to move them to /lib level.
  please, let me know whether the attached patch is what you want and satisfies your needs.

thanks,

Comment 9 Harald Hoyer 2010-06-17 13:29:27 UTC
looks good :)

Comment 10 Anton Arapov 2010-06-17 13:44:00 UTC
Harald, do we need this change in F13 as well?

Comment 11 Harald Hoyer 2010-06-17 15:21:23 UTC
in theory, yes, but nobody complained yet...


Note You need to log in before you can comment on or make changes to this bug.