Bug 556299 - gitweb default conflicts with git-daemon default
Summary: gitweb default conflicts with git-daemon default
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: 12
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Todd Zullinger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-17 18:35 UTC by Daniel Qarras
Modified: 2013-01-10 10:38 UTC (History)
4 users (show)

Fixed In Version: git-1.6.6.1-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-23 05:28:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Daniel Qarras 2010-01-17 18:35:00 UTC
Description of problem:
git-daemon specifies --base-path=/var/lib/git but gitweb.cgi has $projectroot = "/pub/scm" - why not change that to $projectroot = "/var/lib/git" for smoother integration in Fedora?

Thanks.

Version-Release number of selected component (if applicable):
gitweb-1.6.5.2-1.fc12.noarch

Comment 1 Todd Zullinger 2010-01-19 04:18:27 UTC
Thanks for pointing this out.  I agree that we should be setting the same default for gitweb as we do for git-daemon.  This is a simple matter of setting GITWEB_PROJECTROOT = %{_var}/lib/git in the spec file.  I'll add this for the next build.  While I'm at it, I think it might be worth installing an example /etc/gitweb.conf file, to make it easier for folks to learn how to change the defaults.

Comment 2 Daniel Qarras 2010-01-21 18:04:56 UTC
Having a gitweb.conf is a great suggestion, and in fact having used to cvsweb/cvsweg.cgi/cvsweb.conf I first looked for /etc/gitweb.conf before realizing that I need to modify the script itself to make local configurations.

Not sure is cvsweb.conf content related in anyway but perhaps it could provide some hints on what to make configurable.

Cheers!

Comment 3 Todd Zullinger 2010-01-21 18:16:29 UTC
Actually, you don't have to modify the gitweb script.  Gitweb already looks for /etc/gitweb.conf and has quite a number of things that you can configure that way.  You just need to create the /etc/gitweb.conf file manually -- at least, until I push out git-1.6.6.1-1 which will include an example /etc/gitweb.conf file to give you a head start and point you at sources for further documentation.

This is really something that I should make time to suggest upstream and provide a patch to provide.  That way, the default config file would be more likely to stay in sync with the gitweb defaults and be shared among other distributions and git users.

Thanks for the feedback, much appreciated!

Comment 4 Fedora Update System 2010-02-02 14:12:22 UTC
git-1.6.6.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/git-1.6.6.1-1.fc12

Comment 5 Fedora Update System 2010-02-05 01:41:58 UTC
git-1.6.6.1-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update git'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1489

Comment 6 Fedora Update System 2010-02-23 05:28:30 UTC
git-1.6.6.1-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.