Spec URL: http://ruben.fedorapeople.org/rubygem-eventmachine.spec SRPM URL: http://ruben.fedorapeople.org/rubygem-eventmachine-0.12.10-1.fc13.src.rpm Description: EventMachine implements a fast, single-threaded engine for arbitrary network communications. It's extremely easy to use in Ruby. EventMachine wraps all interactions with IP sockets, allowing programs to concentrate on the implementation of network protocols. It can be used to create both network servers and clients. To create a server or client, a Ruby program only needs to specify the IP address and port, and provide a Module that implements the communications protocol. Implementations of several standard network protocols are provided with the package, primarily to serve as examples. The real goal of EventMachine is to enable programs to easily interface with other programs using TCP/IP, especially if custom protocols are required.
Some initial comments - Use "BR: rubygem(rake)" instead of "BR: rubygem-rake" ref: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides - Don't strip binary and create debuginfo rpm correctly. - Test fails like: http://koji.fedoraproject.org/koji/taskinfo?taskID=1952077 - 10 tests errors seem to be due to net connection - 1 error seems to occur occasionally - Please mark document files as %doc appropriately - At least README file, example/ docs/ directories should be marked as %doc - Also I guess tasks/ tests/ web/ directories and Rakefile can be marked as %doc - it may be preferable to split example/ docs/ tasks/ tests/ web/ directories and Rakefile into -doc subpackage (I would do so). - %geminstdir/%gemname.gemspec is not needed. gemspec file is installed under specifications directory. - Use %geminstdir macro in %files as this is defined in the spec file. - License tag should be "GPLv2 or Ruby"
Hi Mamoru, thanks for the review! > - Use "BR: rubygem(rake)" instead of "BR: rubygem-rake" ref: > https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides Fixed. This seems something that should be added to the ruby guidelines as well :-) > - Don't strip binary and create debuginfo rpm correctly. Oops, fixed. > - Test fails like: > http://koji.fedoraproject.org/koji/taskinfo?taskID=1952077 > - 10 tests errors seem to be due to net connection > - 1 error seems to occur occasionally The 10 tests try to open a connection to 127.0.0.1. Apparently this is not allowed by koji. The failure is a timing test which didn't complete in time. This probably depends on how fast the build host is. For now I've added a || : to the %check section. > - Please mark document files as %doc appropriately > - At least README file, example/ docs/ directories should be > marked as %doc > - Also I guess tasks/ tests/ web/ directories and Rakefile can be marked > as %doc > - it may be preferable to split example/ docs/ tasks/ tests/ web/ > directories and Rakefile into -doc subpackage (I would do so). Ok, I've made a -doc subpackage. > - %geminstdir/%gemname.gemspec is not needed. gemspec file is > installed under specifications directory. Fixed. > - Use %geminstdir macro in %files as this is defined in the spec file. Fixed. > - License tag should be "GPLv2 or Ruby" Fixed. New version here: Spec URL: http://ruben.fedorapeople.org/rubygem-eventmachine.spec SRPM URL: http://ruben.fedorapeople.org/rubygem-eventmachine-0.12.10-2.fc13.src.rpm
One issue and one comment * ruby(abi) dependency - "Requires: ruby(abi) = 1.8" is missing. Please add this. ! %doc in -doc subpackage - Not a blocker, however I think %doc attribute in -doc subpackage is redundant because rpm name already shows that the rpm (-doc subpackage) is for documentation. Fix these before importing. ------------------------------------------------------------------ This package (rubygem-eventmachine) is APPROVED by mtasaka ------------------------------------------------------------------
Thanks, I'll fix the issues before importing. New Package CVS Request ======================= Package Name: rubygem-eventmachine Short Description: Ruby/EventMachine library Owners: foo ruben Branches: F-12
Oops, typo. New Package CVS Request ======================= Package Name: rubygem-eventmachine Short Description: Ruby/EventMachine library Owners: ruben Branches: F-12
CVS done (by process-cvs-requests.py).
Please submit push requests for F-12 on bodhi.
rubygem-eventmachine-0.12.10-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-eventmachine-0.12.10-3.fc12
rubygem-eventmachine-0.12.10-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-eventmachine'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1559
Closing.
rubygem-eventmachine-0.12.10-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please include this gem also in F-11 if it's possible.
Sure Package Change Request ====================== Package Name: rubygem-eventmachine New Branches: F-11 Owners: ruben
cvs done.
rubygem-eventmachine-0.12.10-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-eventmachine-0.12.10-3.fc11
rubygem-eventmachine-0.12.10-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: rubygem-eventmachine New Branches: el5 el6 Owners: stahnma Owner is aware of request.
Git done (by process-git-requests).
Package Change Request ====================== Package Name: rubygem-eventmachine New Branches: epel7 Owners: ggillies Owners are aware of request