Bug 556840 - Review Request: apache-commons-exec - Java library to reliably execute external processes from within the JVM
Summary: Review Request: apache-commons-exec - Java library to reliably execute extern...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-19 15:27 UTC by Mohamed El Morabity
Modified: 2010-02-18 22:24 UTC (History)
3 users (show)

Fixed In Version: apache-commons-exec-1.0.1-2.fc12
Clone Of:
Environment:
Last Closed: 2010-02-18 22:24:18 UTC
Type: ---
Embargoed:
akurtako: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mohamed El Morabity 2010-01-19 15:27:32 UTC
Spec URL: http://melmorabity.fedorapeople.org/packages/apache-commons-exec/apache-commons-exec.spec
SRPM URL: http://melmorabity.fedorapeople.org/packages/apache-commons-exec/apache-commons-exec-1.0.1-1.fc12.src.rpm
Description: Commons Exec is a library for dealing with external process execution and
environment management in Java.

This package builds fine in mock, rpmlint complains on this:
   apache-commons-exec.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-exec
But this can be ignored.

Comment 1 Alexander Kurtakov 2010-02-03 14:31:05 UTC
I'm taking this one.

Comment 2 Alexander Kurtakov 2010-02-03 14:40:18 UTC
Review:   
OK: rpmlint must be run on every package. Output as written by the reporter, only one false positive.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
OK: All build dependencies must be listed in BuildRequires
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's %files listings.
OK: Permissions on files must be set properly. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of the application. 

FIXIT: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. 

Your package owns %{_datadir}/maven2/pom and %{_mavendepmapfragdir} while it should own only the files in them e.g. %{_datadir}/maven2/poms/* and
%{_mavendepmapfragdir}/*. Btw, there is a macro %{_mavenpomdir} that evals to %{_datadir}/maven2/pom which you can use if you want. 

OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.

Only one small issue and the package will be good.

Comment 3 Alexander Kurtakov 2010-02-03 14:41:59 UTC
One more thing you need 
Requires(post):       jpackage-utils
Requires(postun):     jpackage-utils
to ensure that %update_maven_depmap will be present during post and postun.

Comment 4 Mohamed El Morabity 2010-02-03 21:51:04 UTC
Thanks for your review. Here is a new version of the RPM, based on your remarks:
Spec URL: http://melmorabity.fedorapeople.org/packages/apache-commons-exec/apache-commons-exec.spec
SRPM URL: http://melmorabity.fedorapeople.org/packages/apache-commons-exec/apache-commons-exec-1.0.1-2.fc12.src.rpm

Comment 5 Alexander Kurtakov 2010-02-03 21:57:34 UTC
Thanks for the quick fixes.

This package is APPROVED.

Comment 6 Mohamed El Morabity 2010-02-03 22:05:55 UTC
New Package CVS Request
=======================
Package Name: apache-commons-exec
Short Description: Java library to reliably execute external processes from within the JVM
Owners: melmorabity
Branches: F-12
InitialCC:

Comment 7 Kevin Fenzi 2010-02-04 02:33:18 UTC
CVS done (by process-cvs-requests.py).

Comment 8 Fedora Update System 2010-02-04 03:31:05 UTC
apache-commons-exec-1.0.1-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/apache-commons-exec-1.0.1-2.fc12

Comment 9 Fedora Update System 2010-02-05 01:50:09 UTC
apache-commons-exec-1.0.1-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update apache-commons-exec'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1509

Comment 10 Fedora Update System 2010-02-18 22:24:13 UTC
apache-commons-exec-1.0.1-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.