Bug 557573 - [abrt] crash in bzr-gtk-0.97.0-2.fc12
Summary: [abrt] crash in bzr-gtk-0.97.0-2.fc12
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: bzr
Version: 12
Hardware: i686
OS: Linux
low
medium
Target Milestone: ---
Assignee: Toshio Ernie Kuratomi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:4b0c976f
: 562567 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-21 20:50 UTC by Felix Möller
Modified: 2010-12-04 00:01 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-12-04 00:01:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (2.00 KB, text/plain)
2010-01-21 20:50 UTC, Felix Möller
no flags Details
Patch to make bzr's patch handling more lenient (1.45 KB, patch)
2010-01-22 11:12 UTC, Toshio Ernie Kuratomi
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Launchpad 502076 0 None None None Never

Description Felix Möller 2010-01-21 20:50:38 UTC
abrt 1.0.3 detected a crash.

How to reproduce: Try to open the patch file from https://mozilla-plugin.forge.funambol.org/servlets/TrackerDownload/remcurreport/true/template/ViewAttachment.vm/attachid/453/filename/0001-fix-preferences.patch and you will get the attached crash.
Attached file: backtrace
cmdline: /usr/bin/python /usr/bin/bzr-handle-patch /home/fm/0001-fix-preferences.patch
component: bzr-gtk
executable: /usr/bin/bzr-handle-patch
kernel: 2.6.31.9-174.fc12.i686.PAE
package: bzr-gtk-0.97.0-2.fc12
uuid: 4b0c976f

Comment 1 Felix Möller 2010-01-21 20:50:41 UTC
Created attachment 386005 [details]
File: backtrace

Comment 2 Toshio Ernie Kuratomi 2010-01-22 04:25:45 UTC
This has been filed upstream before.  Putting upstream bug# in.  However, this looks like a bug in bzr code rather than bzr-gtk.  Looking further.

Comment 3 Toshio Ernie Kuratomi 2010-01-22 11:12:03 UTC
I'm able to fix this bug with a patch to bzr's patch handling to make it more lenient.  (Currently, that patch handling code doesn't accept "junk" before and after the individual patches within a file.).  Will attach a patch.

hno, do you know if the patches.py code is meant to handle any patch file?  If so, this is appropriate.  If it's really only meant to handle bzr-generated patches, then bzr-gtk is misusing the bzrlib code.

Comment 4 Toshio Ernie Kuratomi 2010-01-22 11:12:50 UTC
Created attachment 386120 [details]
Patch to make bzr's patch handling more lenient

Comment 5 Toshio Ernie Kuratomi 2010-02-08 16:55:34 UTC
*** Bug 562567 has been marked as a duplicate of this bug. ***

Comment 6 Damian Wrobel 2010-03-16 20:24:26 UTC

How to reproduce
-----
1. open the following url in firefox:
http://www.splitted-desktop.com/~gbeauchesne/libva/patches/
2. click on the link 033_g45_add_rgba_subpic.patch 
3. open the file with Baazar (crash is reproducible in 100%)

Comment 7 Toshio Ernie Kuratomi 2010-04-13 13:18:48 UTC
My patch to bzr to fix this is in bzr-2.2b1.  We could safely backport it to current bzr packages.  Also need a patch to bzr-gtk to turn this functionality on.  I have a patch for that linked  to the upstream bug report but upstream needs it cconditionalized on having a new enough bzr.

Comment 8 Toshio Ernie Kuratomi 2010-04-13 17:09:22 UTC
New fix for bzr-gtk submitted upstream: https://code.launchpad.net/~toshio/bzr-gtk/handle-patch-dirty/+merge/23330

If accepted, we'll likely want to backport both the bzr and bzr-gtk fixes back to F-12 and F-13.

Comment 9 Damian Wrobel 2010-07-30 19:37:22 UTC
Package: bzr-gtk-0.97.0-4.fc12
Architecture: i686
OS Release: Fedora release 12 (Constantine)


How to reproduce
-----
1. Add patch as an attachment in the thunderbird program
2. Double click the patch to see its content
3.

Comment 10 Damian Wrobel 2010-10-11 18:18:21 UTC
Package: bzr-gtk-0.98.0-1.fc13
Architecture: i686
OS Release: Fedora release 13 (Goddard)


Comment
-----
Just tried to open a C source file.

Comment 11 Bug Zapper 2010-11-04 00:18:18 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 12 Bug Zapper 2010-12-04 00:01:46 UTC
Fedora 12 changed to end-of-life (EOL) status on 2010-12-02. Fedora 12 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.