abrt 1.0.3 detected a crash. Comment: i was rsyncing a folder from a cifs share served on Windows 7 Attached file: backtrace cmdline: rsync -a 'Good Good M' /home/jhford/Music/ --progress component: rsync executable: /usr/bin/rsync kernel: 2.6.31.12-174.2.3.fc12.i686.PAE package: rsync-3.0.7-1.fc12 rating: 4 reason: Process was terminated by signal 6 (Aborted)
Created attachment 386229 [details] File: backtrace
By looking at the attachment, what happens is a stack overflow caused by a very long path to a file. I added a patch fixing this issue by skipping such a file. Giving the patch to upstream, they might figure out a better solution.
Reference to upstream bugzilla: https://bugzilla.samba.org/show_bug.cgi?id=7057
rsync-3.0.7-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rsync-3.0.7-2.fc12
rsync-3.0.7-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rsync'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rsync-3.0.7-2.fc12
rsync-3.0.7-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Upstream claims the stack overflow cannot happen; we have no evidence that it is real besides this one abrt report. Why does this merit pushing an update to all Fedora users?
I submitted the update to testing, stable push has been done automatically. If there is a problem with the patch, I think posting a comment there while it was in testing would be appropriate. Do you have any evidence that the patch breaks something? I agree that it seems redundant on sane systems, but I don't think it can actually break something. At this point, I'd also like to know a result from reporter. Does the patch fix the issue for you?
(In reply to comment #8) > I submitted the update to testing, stable push has been done automatically. If > there is a problem with the patch, I think posting a comment there while it was > in testing would be appropriate. Sorry, I had neglected to CC myself on this bug, so I had no idea the update had gone to testing until I happened to check on 2010-03-17 and saw it was already in stable. I had assumed the update was on hold indefinitely until more information about the issue came to light. > Do you have any evidence that the patch breaks > something? No, given that I think the code is unreachable. But neither do you have any evidence that it fixes something. IMO, that should be a minimum requirement for submitting an update.
rsync-3.0.7-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rsync-3.0.7-3.fc12
rsync-3.0.7-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rsync-3.0.7-3.fc13
The original patch has been proven ineffective, the last update contains patch provided by upstream, which should finally fix the issue. Please test new packages linked in comment 10 and comment 11.
rsync-3.0.7-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
rsync-3.0.7-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.