Bug 558089 - no icon in sysprof's menu entry
Summary: no icon in sysprof's menu entry
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: sysprof
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Gianluca Sforna
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-23 16:15 UTC by Christian Krause
Modified: 2011-07-02 19:29 UTC (History)
3 users (show)

Fixed In Version: sysprof-1.1.6-3.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-27 23:51:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch for the spec file to fix the issue by symlinking some icons (1.55 KB, patch)
2011-03-06 21:45 UTC, Christian Krause
no flags Details | Diff

Description Christian Krause 2010-01-23 16:15:24 UTC
Description of problem:
no icon in sysprof's menu entry

Version-Release number of selected component (if applicable):
sysprof-1.1.4-1.fc12.i686


How reproducible:
100%

Steps to Reproduce:
1. look at sysprof's menu entry (Applications / Programming / sysprof)
  
Actual results:
no icon

Expected results:
icon should be displayed ;-)

Additional info:
The sysprof's desktop file refers to the icon: 
Icon=sysprof-icon
however the icons in the package are named:
/usr/share/pixmaps/sysprof-icon-16.png
/usr/share/pixmaps/sysprof-icon-24.png
/usr/share/pixmaps/sysprof-icon-32.png
/usr/share/pixmaps/sysprof-icon-48.png

Probably it would be sufficient to place the icons in /usr/share/icons/hicolor/<resolution>/sysprof-icon.png

Comment 1 Carl G. 2010-10-17 00:09:09 UTC
Still relevant on F14.

Comment 2 Gianluca Sforna 2010-10-17 09:00:33 UTC
Sorry, this have been not a priority for me so it's sitting there for longer than needed.

I had a quick look and it seems the path to the 4 installed icons is hardcoded in sysprof.c so I guess I can't just move the files where they belong and be done with it.

I could probably make symlinks, but I guess a proper fix is to change the code to use some other GTK API to set the icon, maybe:
http://library.gnome.org/devel/gtk/unstable/GtkWindow.html#gtk-window-set-icon-list

so I'mm CCing the author for an opinion.

Soren, can you help me here?

Comment 3 Bug Zapper 2010-11-04 00:07:51 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Christian Krause 2010-11-05 00:26:06 UTC
(In reply to comment #1)
> Still relevant on F14.

And also present in F13.

Comment 5 Gianluca Sforna 2010-11-05 07:54:27 UTC
Yeah, it affects all branches. 
If anyone is able to create a patch for this, I'll apply it ASAP

Comment 6 Christian Krause 2011-03-06 21:45:19 UTC
Created attachment 482553 [details]
patch for the spec file to fix the issue by symlinking some icons

I have attached a patch to fix the problem. If you like, I can just use my provenpackage powers to fix it myself.

Comment 7 Gianluca Sforna 2011-03-07 09:26:40 UTC
Thanks a lot Christian, if you have time just go ahead and push it

Comment 8 Fedora Update System 2011-06-24 14:06:19 UTC
sysprof-1.1.6-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/sysprof-1.1.6-3.fc14

Comment 9 Fedora Update System 2011-06-24 14:16:55 UTC
sysprof-1.1.6-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/sysprof-1.1.6-3.fc15

Comment 10 Fedora Update System 2011-06-24 17:56:03 UTC
Package sysprof-1.1.6-3.fc14:
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing sysprof-1.1.6-3.fc14'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/sysprof-1.1.6-3.fc14
then log in and leave karma (feedback).

Comment 11 Christian Krause 2011-06-26 18:53:28 UTC
Gianluca, thanks for fixing the issue!

Sorry that I didn't had the time to commit the patch earlier...

Comment 12 Gianluca Sforna 2011-06-26 20:56:16 UTC
No problems :)

I modified it a bit because for some reason it was not working as is, otherwise it really helped. Thanks again!

PS. If testers can also add karma to the F14 update it would be really nice...

Comment 13 Fedora Update System 2011-06-27 23:51:11 UTC
sysprof-1.1.6-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2011-07-02 19:29:17 UTC
sysprof-1.1.6-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.