Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-Net-Whois/perl-Net-Whois.spec SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-Net-Whois/perl-Net-Whois-1.9-2.el5.src.rpm Description: Net::Whois::Domain new() attempts to retrieve and parse the given domain's "whois" information from the InterNIC (whois.internic.net). If the server could not be contacted, is too busy, or otherwise does not process the query then the constructor does not return a reference and your object is undefined. If the constructor returns a reference, that reference can be used to access the various attributes of the domains' whois entry assuming that there was a match. The member function ok returns 1 if a match 0 if no match.
Please attach "rpmlint" on both .src.rpm and .spec files. Please attach link to Koji build.
- Package meets naming and packaging guidelines Yes - Spec file matches base package name. Yes - Spec has consistent macro usage. Yes - Meets Packaging Guidelines. Yes. - License Yes - License field in spec matches Yes - License file included in package Yes - Spec in American English Yes - Spec is legible. Yes - Sources match upstream md5sum: N/A - Package needs ExcludeArch No. - BuildRequires correct Yes - Spec handles locales/find_lang N/A - Package is relocatable and has a reason to be. N/A - Package has %defattr and permissions on files is good. Yes - Package has a correct %clean section. Yes - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Yes - Package is code or permissible content. Yes - Doc subpackage needed/used. N/A - Packages %doc files don't affect runtime. Yes - Headers/static libs in -devel subpackage. N/A - Spec has needed ldconfig in post and postun N/A - .pc files in -devel subpackage/requires pkgconfig N/A - .so files in -devel subpackage. N/A - -devel package Requires: %{name} = %{version}-%{release} N/A - .la files are removed. N/A - Package is a GUI app and has a .desktop file N/A - Package compiles and builds on at least one arch. Yes - Package has no duplicate files in %files. Yes - Package doesn't own any directories other packages own. Yes - Package owns all the directories it creates. Yes - No rpmlint output. Pending - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) $ rpm -qp /tmp/erl-Net-Whois-1.9-2.el5.noarch.rpm --provides perl(Net::Whois) = 1.9 perl(Net::Whois::Domain) perl-Net-Whois = 1.9-2.el5 $ rpm -qp /tmp/erl-Net-Whois-1.9-2.el5.noarch.rpm --requires perl >= 0:5.004 perl(Carp) perl(Exporter) perl(IO::File) perl(IO::Socket) perl(strict) perl(vars) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 $ SHOULD Items: - Should build in mock. Yes - Should build on all supported archs Yes. - Should function as described. N/A - Should have sane scriptlets. N/A - Should have subpackages require base package with fully versioned depend. N/A - Should have dist tag Yes - Should package latest version Yes - check for outstanding bugs on package. (For core merge reviews) N/A
[coec@rsim tmp]$ rpmlint perl-Net-Whois.spec perl-Net-Whois-1.9-2.el5.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. [coec@rsim tmp]$ http://koji.fedoraproject.org/koji/taskinfo?taskID=1944783 Thanks for the review. CC
> - No rpmlint output. > Pending Fixed.
New Package CVS Request ======================= Package Name: perl-Net-Whois Short Description: Get and parse "whois" domain data from InterNIC Owners: coec Branches: F-11 F-12 EL-5 InitialCC: coec
CVS done (by process-cvs-requests.py).