Please attach the following:

rpmlint output on the .spec and .src.rpm files.

a link to the koji build.  Run:

koji build --scratch dist-5E-epel-testing-candidate /path/mypkg.src.rpm

to get this.

[coec@rsim tmp]$ rpmlint perl-Net-Whois-IP.spec perl-Net-Whois-IP-1.04-1.el5.src.rpm
1 packages and 1 specfiles checked; 0 errors, 0 warnings.
[coec@rsim tmp]$

http://koji.fedoraproject.org/koji/taskinfo?taskID=1944792


Thanks for the review.

CC

- Package meets naming and packaging guidelines
Yes
- Spec file matches base package name.
Yes
- Spec has consistent macro usage.
Yes
- Meets Packaging Guidelines.
Yes.
- License
Yes
- License field in spec matches
Yes
- License file included in package
Yes
- Spec in American English
Yes
- Spec is legible.
Yes
- Sources match upstream md5sum:
N/A

- Package needs ExcludeArch
No.
- BuildRequires correct
Yes
- Spec handles locales/find_lang
N/A
- Package is relocatable and has a reason to be.
N/A
- Package has %defattr and permissions on files is good.
Yes
- Package has a correct %clean section.
Yes
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Yes
- Package is code or permissible content.
Yes
- Doc subpackage needed/used.
N/A
- Packages %doc files don't affect runtime.
Yes

- Headers/static libs in -devel subpackage.
N/A
- Spec has needed ldconfig in post and postun
N/A
- .pc files in -devel subpackage/requires pkgconfig
N/A
- .so files in -devel subpackage.
N/A
- -devel package Requires: %{name} = %{version}-%{release}
N/A
- .la files are removed.
N/A
- Package is a GUI app and has a .desktop file
N/A
- Package compiles and builds on at least one arch.
Yes
- Package has no duplicate files in %files.
Yes
- Package doesn't own any directories other packages own.
Yes
- Package owns all the directories it creates.
Yes
- No rpmlint output.
Yes
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

$ rpm -qp /tmp/perl-Net-Whois-IP-1.04-1.el5.noarch.rpm --provides
  perl(Net::Whois::IP) = 1.04
  perl-Net-Whois-IP = 1.04-1.el5
$ rpm -qp /tmp/perl-Net-Whois-IP-1.04-1.el5.noarch.rpm --requires
  perl(Carp)  
  perl(Exporter)  
  perl(IO::Socket)  
  perl(strict)  
  perl(vars)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1
$ 


SHOULD Items:

- Should build in mock.
Yes
- Should build on all supported archs
Yes.
- Should function as described.
N/A
- Should have sane scriptlets.
N/A
- Should have subpackages require base package with fully versioned depend.
N/A
- Should have dist tag
Yes
- Should package latest version
Yes
- check for outstanding bugs on package. (For core merge reviews)
N/A

rpmlint output:

[root@rpm02 SPECS]# rpmlint ~/perl-Net-Whois-IP-1.04-1.el5.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[root@rpm02 SPECS]# rpmlint perl-Net-Whois-IP.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.


Thanks for the review.

CC

CVS flag was set, but there's no CVS request in this ticket.  If you need something from the CVS admins, please file a proper CVS request.  http://fedoraproject.org/wiki/CVS_admin_requests

Apologies.

New Package CVS Request
=======================
Package Name: perl-Net-Whois-IP
Short Description: Perl extension for looking up the whois information for ip addresses
Owners: coec
Branches: EL-5 F-11 F-12
InitialCC: coec

CVS done (by process-cvs-requests.py).

philipp: Please remember to assign packages you are reviewing to yourself and move 
them from NEW to ASSIGNED. ;)

(In reply to comment #7)
> CVS done (by process-cvs-requests.py).
> 
> philipp: Please remember to assign packages you are reviewing to yourself and
> move 
> them from NEW to ASSIGNED. ;)    

I thought I had:

philipp  	2010-01-26 12:03:01 EST  	 Status  	NEW  	ASSIGNED
Whiteboard 	NotReady 	
Flag 	fedora-review? 	fedora-review+

Package Change Request
======================
Package Name: perl-Net-Whois-IP
New Branches: epel7 el6
Owners: fab coec
InitialCC:

Git done (by process-git-requests).

el6 exists.