Bug 558562 - superfluous Samba data is written to /etc/samba/smb.conf
Summary: superfluous Samba data is written to /etc/samba/smb.conf
Alias: None
Product: RHQ Project
Classification: Other
Component: Configuration
Version: 1.4
Hardware: All
OS: Linux
high vote
Target Milestone: ---
: ---
Assignee: Ian Springer
QA Contact: John Sefler
Depends On:
Blocks: rhq4
TreeView+ depends on / blocked
Reported: 2010-01-25 17:11 UTC by John Sefler
Modified: 2013-08-06 00:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-02-16 19:20:03 UTC

Attachments (Terms of Use)

Description John Sefler 2010-01-25 17:11:33 UTC
Description of problem:
When creating a Samba share through iManage, an unexpected parameter is being set within the share's section name.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Create a Samba share through the iManage UI.  Set the following UI fields:
Resource Name:  testResourceName
Name:           testName
Path:           /tmp/testNameShare
click Submit
2. On the agent's filesystem:
cat /etc/samba/smb.cnf

Notice the newly added samba section [testName].  The "name = testName" parameter is superfluous and unrecognised by samba's own testparm configuration checking tool.

Actual results:
   name = testName
   path = /tmp/testNameShare

Expected results:
   path = /tmp/testNameShare

Additional info:
Try running on the command line:
testparm -sv --section-name=testName

Processing section "[testName]"
Unknown parameter encountered: "name"
Ignoring unknown parameter "name"
Loaded services file OK.
	path = /tmp/testNameShare

Comment 1 wes hayutin 2010-02-16 16:52:04 UTC
Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs.

new = Tracking + FutureFeature + SubBug

Comment 2 wes hayutin 2010-02-16 16:58:01 UTC
making sure we're not missing any bugs in rhq_triage

Comment 3 Corey Welton 2010-09-13 20:17:26 UTC
ps -- can we do semantic validation when a config is saved?

Comment 4 Corey Welton 2010-09-13 20:17:53 UTC
s/ps/ips/  -- that question was directed at you, ian :)

Comment 5 Ian Springer 2011-02-16 19:18:59 UTC
Corey, yes, when the user clicks the Save button, updateConfiguration() is called on the plugin, and if the plugin finds issues with certain property values, it can set validation error messages on those properties and then send back a failed response to the Server, which includes the property-specific errors. The GUI will then display the property-specific errors next to the corresponding properties.

Comment 6 Ian Springer 2011-02-16 19:20:03 UTC
Closing this, since the samba and other Linux plugins are no longer a priority.

Note You need to log in before you can comment on or make changes to this bug.