Bug 558566 - Merge Review: perl-AppConfig - Perl module for reading config files
Summary: Merge Review: perl-AppConfig - Perl module for reading config files
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-25 17:21 UTC by Stepan Kasal
Modified: 2011-01-19 09:39 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-04 08:55:07 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+


Attachments (Terms of Use)

Description Stepan Kasal 2010-01-25 17:21:11 UTC
Fedora Merge Review: perl-AppConfig

http://cvs.fedoraproject.org/viewvc//devel/perl-AppConfig

Comment 1 Marcela Mašláňová 2010-01-27 10:36:27 UTC
rpmlint on every package.
name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
OK The sources used to build the package must match the upstream source.
OK successful koji compilation.
OK correct BuildRequires, Requires.
OK proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
OK static libraries must be in a -static package.
OK pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
OK GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

Comment 2 Marcela Mašláňová 2010-02-04 08:55:07 UTC
This could be closed now.

Comment 3 Mathieu Bridon 2011-01-19 09:07:45 UTC
This package is in EPEL5, but not in EPEL6. Is there any reason for that?

I would like to see this package in EPEL6, and I am willing to help co-maintain it.

Comment 4 Mathieu Bridon 2011-01-19 09:39:50 UTC
Nevermind, I just saw it's in the RHEL6 Client repository (I was only looking at the Server one).

Sorry for the spam.


Note You need to log in before you can comment on or make changes to this bug.