Spec URL: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-xmpp4r/rubygem-xmpp4r.spec SRPM URL: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-xmpp4r/rubygem-xmpp4r-0.5-1.el5.src.rpm Description: XMPP4R is an XMPP/Jabber library for Ruby This is my first package, and I am seeking a sponsor
Some notes * %define -> %global - Now we prefer to use %global instead of %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * Unneeded macros - The defined %ruby_sitelib seems to be used nowhere. * Testing - As this package contains test/ directory, please add %check stage and execute some test program (like $ rake test ). * Directory ownership issue https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes - The directories themselves are not owned by any packages. ------------------------------------------------------------------- /usr/lib/ruby/gems/1.8/gems/xmpp4r-0.5/data /usr/lib/ruby/gems/1.8/gems/xmpp4r-0.5/data/doc /usr/lib/ruby/gems/1.8/gems/xmpp4r-0.5/data/doc/xmpp4r ------------------------------------------------------------------- * %doc specification - I don't see the necessity to use %doc in -doc subpackage as its name already shows that this (-doc) subpackage is for documentation.
One more thing * Summary - "XMPP4R is an" is redundant on Summary
Some more comments. * rpmlint messages -------------------------------------------------------------- rubygem-xmpp4r.src: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 57) rubygem-xmpp4r.src: W: strange-permission rubygem-xmpp4r-examples.patch 0600L rubygem-xmpp4r.src: W: strange-permission rubygem-xmpp4r.spec 0600L rubygem-xmpp4r.src: W: strange-permission xmpp4r-0.5.gem 0600L -------------------------------------------------------------- - Please fix indentation. You should use spaces or tabs, not both (cosmetic issue) - All files in .src.rpm should have 0644 permisson.
* Fixed the src.rpm file permissions * Replaced tabs with spaces * Removed the redundant "XMPP4R is an" from the Summary * removed the %doc lines in the -doc package * data, data/doc and data/doc/xmpp4r now have owners * Tests enabled * Removed unused macro * Replaced the "%define"s with "%global" New Spec in the same location: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-xmpp4r/rubygem-xmpp4r.spec New SRPM: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-xmpp4r/rubygem-xmpp4r-0.5-2.fc12.src.rpm Relevant RPM Lint output ee0mdc:vampire:~ $ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm | grep -v yaml rubygem-xmpp4r.src: W: patch-not-applied Patch0: rubygem-xmpp4r-examples.patch rubygem-xmpp4r.src: W: patch-not-applied Patch1: rubygem-xmpp4r-tests.patch rubygem-xmpp4r-doc.noarch: W: no-documentation The patches have been applied, and the "no-documentation" is the doc package. Thank you very much for your time so far Mamoru
(In reply to comment #4) > New SRPM: > http://people.bath.ac.uk/ee0mdc/rpm/rubygem-xmpp4r/rubygem-xmpp4r-0.5-2.fc12.src.rpm gets 403 (Forbidden)
Oops, sorry. Should be fixed now
Well, - "Requires: ruby(rubygems)" on -doc subpackge is not needed, because -doc subpackage has "Requires: %{name}" and %{name} has "Requires: rubygems" Other things are okay. ---------------------------------------------------------------- This package (rubygem-xmpp4r) is APPROVED by mtasaka ---------------------------------------------------------------- If you are still seeking for sponsors: Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". After you request for sponsorship a mail will be sent to sponsor members automatically (which is invisible for you) which notifies that you need a sponsor. After that, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you. If you want to import this package into Fedora 11/12, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me.
I am still seeking a sponsor. I've just requested membership of the packager group. My FAS account name is tremble, Mark
New Package CVS Request ======================= Package Name: rubygem-xmpp4r Short Description: an XMPP/Jabber library for Ruby Owners: tremble Branches: F-11 F-12 EL-5
Now I am sponsoring you. Please set fedora-cvs flag to ? (also in -icalendar / -nokogiri review tickets)
CVS done (by process-cvs-requests.py).
Closing (as devel/F-12 build succeeded and push request submitted for F-12)