This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 558849 - Review Request: Jep - Java Embedded Python
Review Request: Jep - Java Embedded Python
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2010-01-26 10:09 EST by John Matthews
Modified: 2010-12-17 10:27 EST (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-12-17 10:27:07 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description John Matthews 2010-01-26 10:09:49 EST
Spec URL: http://jmatthews.fedorapeople.org/jep/jep.spec
SRPM URL: http://jmatthews.fedorapeople.org/jep/jep-2.4-1.fc12.src.rpm
Description: 
Jep embeds CPython in Java. It is safe to use in a heavily threaded environment,
it is quite fast and its stability is a main feature and goal.
Comment 1 Guido Grazioli 2010-04-07 14:05:33 EDT
Hi i'd like to take up the review; some preliminar notes:

* project name seems to be jepp (while Jep is the main class)
* use %global instead of %define
* pls fix indentation
* group for -javadoc is "Documentation"
* -javadoc pkg require jpackage-tools too
* if you put DSO in %{_libdir}/%{name}, shouldnt you add that dir to ld.so.cond.d?
* man page: use jep.1.*
* use install -p to preserve timestamps
Comment 2 Chen Lei 2010-05-05 05:08:47 EDT
Some minor problems:
1.Jni files are dlopend by jar files, so /sbin/ldconfig in %post and %postun is useless.
2.BuildRequires:  gcc is not needed.
3.
Use BuildRequires: java-devel >= 1:1.6.0 and Requires:  java >= >= 1:1.6.0 instead of 1.5.0
4.
mkdir -p $RPM_BUILD_ROOT is not needed.
5.
examples should be installed into %{_docdir}
install -d -m 755 ${RPM_BUILD_ROOT}%{_docdir}/%{name}-%{version}/examples
cp *.py ${RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/examples
Comment 3 Alexander Kurtakov 2010-08-31 01:54:30 EDT
John, Are you still interested in getting this package into Fedora?
Comment 4 John Matthews 2010-08-31 13:02:03 EDT
Hello Alex,

Yes I would like to see this package get into Fedora.  

I will upload an updated srpm for review this week.
Comment 5 Alexander Kurtakov 2010-10-13 15:00:39 EDT
Ping?
Comment 6 John Matthews 2010-10-13 16:18:35 EDT
Hi Alex,

I still would like to see this get into Fedora, but I won't have time to work on this till mid December.  

If someone else is interested in picking this up, go for it.  Otherwise I will revisit this, update to latest Jep and fix the noted packaging errors when my schedule permits.

Note You need to log in before you can comment on or make changes to this bug.