+++ This bug was initially created as a clone of Bug #559253 +++

+++ This bug was initially created as a clone of Bug #558550 +++

Spec URL: http://linville.fedorapeople.org/iwl5150-firmware.spec
SRPM URL: http://linville.fedorapeople.org/iwl5150-firmware-8.24.2.2-1.fc11.src.rpm
Description:
This package contains the firmware required by the iwlagn driver
for Linux to support the iwl5150 hardware.  Usage of the firmware
is subject to the terms and conditions contained inside the provided
LICENSE file. Please read it carefully.

--- Additional comment from jdieter on 2010-01-25 14:05:37 EST ---

Seeing as I'm the one who reported this, I'll go ahead and take it.  I don't actually have the hardware, so I can't test that it actually works.

--- Additional comment from jdieter on 2010-01-25 14:25:20 EST ---

SHA256SUM:
d253e6ff6624639aded67c82df98b2bc4a66eb66400848d5614921d513540cf9 from SRPM
d253e6ff6624639aded67c82df98b2bc4a66eb66400848d5614921d513540cf9 from http://intellinuxwireless.org/iwlwifi/downloads/iwlwifi-5150-ucode-8.24.2.2.tgz

Good:
* The package is named according to the Package Naming Guidelines.
* The spec file name matches the base package.
* The package meets the Packaging Guidelines.
* The package is licensed with a Fedora approved license (Redistributable, no modification permitted - acceptable for firmware)
* The License field in the package spec file matches the actual license.
* LICENSE is included in %doc.
* The spec file is written in American English.
* The spec file for the package is legible.
* The sources used to build the package matches the upstream source.
* The package successfully compiles and builds into binary rpm on i386.
* All build dependencies are listed in BuildRequires.
* The package owns all directories that it creates.
* The package doesn't contain any duplicate files in the %files listing.
* Permissions on files are set properly.
* The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
* The package consistently uses macros.
* The package contains code and permissable content.
* All %doc files do not affect the runtime of the application.
* At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT).
* All filenames in rpm packages are valid UTF-8.
* Source URL is canonical
* Buildroot has all required elementsx
* All necessary BuildRequires listed
* All desired features are enabled
* Group Tag is from the official list

Bad:
* All paths begin with macros - firmware is installed directly into /lib/firmware rather than %lib/firmware, but I'm assuming this is necessary as it lives in the same place on 32 and 64 bit architectures?

Based on the assumption above, I'm listing this as approved.

--- Additional comment from linville on 2010-01-25 15:00:11 EST ---

Yes, the /lib/firmware comment is correct.  I dunno who influences/produces such things, but a %{_yes_I_mean_slash_lib} macro would be nice -- of course, if it is always /lib anyway I guess it doesn't really matter... :-)

--- Additional comment from linville on 2010-01-25 15:03:34 EST ---

New Package CVS Request
=======================
Package Name: iwl5150-firmware
Short Description: Firmware for Intel® Wireless 5150 A/G/N network adaptors
Owners: linville
Branches: F-11 F-12 EL-5
InitialCC: linville

--- Additional comment from tibbs.edu on 2010-01-27 00:26:05 EST ---

CVS done (by process-cvs-requests.py).