Hide Forgot
Description of problem: The script "/etc/cron.weekly/98-zfs-fuse-scrub" fails with the following errors: /etc/cron.weekly/98-zfs-fuse-scrub: line 14: list: command not found Found these pools: /etc/cron.weekly/98-zfs-fuse-scrub: line 23: unexpected EOF while looking for matching `"' /etc/cron.weekly/98-zfs-fuse-scrub: line 24: syntax error: unexpected end of file Version-Release number of selected component (if applicable): zfs-fuse-0.6.0-6.fc11.x86_64 How reproducible: 100% - Script fails each time it is run. Steps to Reproduce: 1. /etc/cron.weekly/98-zfs-fuse-scrub 2. observe errors Actual results: zfs scrub fails to run, script returns the following errors: /etc/cron.weekly/98-zfs-fuse-scrub: line 14: list: command not found Found these pools: /etc/cron.weekly/98-zfs-fuse-scrub: line 23: unexpected EOF while looking for matching `"' /etc/cron.weekly/98-zfs-fuse-scrub: line 24: syntax error: unexpected end of file Expected results: zfs scrub to run on the available zpool(s) Additional info: The immediate problem appears to be due to missing backticks on line 14 when declaring the 'pools' variable: pools=$zpool list -H | cut -f1 However, there is no error checking performed after the declaration. Seeing as ZFS_WEEKLY_SCRUB is set to "yes" by default if zfs-fuse is installed but there are no pools defined the script will blindly continue anyway - not really ideal. Finally, the last line is missing a double quote to close the echo statement.
Thank you for the report! The backticks and quotes have been fixed and will be released within a week. If no pools are found, the "for" loop has no iterations. Would you like a better message?
(In reply to comment #1) > Thank you for the report! > > The backticks and quotes have been fixed and will be released within a week. Awesome! Thanks! > If no pools are found, the "for" loop has no iterations. Would you like a > better message? Ah yes, of course. Except, with the backticks and quotes fixed, the output when not finding any pools is: Found these pools: ZFS Fuse automatic scrub start done. Use '/usr/bin/zpool status' to see progress. Which implies that it still ran the scrub - which isn't correct. As this is run via cron and any output is ultimately emailed to 'root' I would only really expect to see output if something bad had happened. Does that sound sensible?
So, I'll change the output to "No pools found." Only sending output if there was a problem is sensible. Do I have to solve this in the script, or does cron have a mechanism for this?
Changed the script to have no output if no pools are found.
(In reply to comment #4/3) > Changed the script to have no output if no pools are found. Thanks! > Only sending output if there was a problem is sensible. Do I have to solve > this in the script, or does cron have a mechanism for this? All cron will do is email all output from the script to the cron owner. Generally, when things go wrong, the command being run will let you know. So in the case of your script, you could probably get away with removing any 'echo' statements and let the 'zpool' command report back if it can't run.
This message is a reminder that Fedora 11 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 11. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '11'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 11's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 11 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
zfs-fuse-0.6.9-0.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-0.fc12
zfs-fuse-0.6.9-0.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zfs-fuse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-0.fc12
zfs-fuse-0.6.9_beta3-0.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9_beta3-0.fc12
zfs-fuse-0.6.9_beta3-6.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9_beta3-6.fc13
zfs-fuse-0.6.9_beta3-0.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9_beta3-0.el5
zfs-fuse-0.6.9_beta3-0.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zfs-fuse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9_beta3-0.el5
zfs-fuse-0.6.9_beta3-6.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zfs-fuse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9_beta3-6.fc13
zfs-fuse-0.6.9_beta3-0.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zfs-fuse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9_beta3-0.fc12
zfs-fuse-0.6.9-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-2.fc13
zfs-fuse-0.6.9-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-2.fc12
zfs-fuse-0.6.9-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-4.fc12
zfs-fuse-0.6.9-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-4.fc13
zfs-fuse-0.6.9-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-5.fc13
zfs-fuse-0.6.9-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-5.fc12
zfs-fuse-0.6.9-5.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zfs-fuse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-5.fc12
zfs-fuse-0.6.9-5.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zfs-fuse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zfs-fuse-0.6.9-5.fc13
zfs-fuse-0.6.9_beta3-0.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
zfs-fuse-0.6.9-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
zfs-fuse-0.6.9-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.