Bug 559800 - False positive in init script
False positive in init script
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: rpmlint (Show other bugs)
12
All Linux
low Severity medium
: ---
: ---
Assigned To: Ville Skyttä
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-28 22:20 EST by W. Michael Petullo
Modified: 2010-01-29 11:19 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-01-29 11:19:55 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Dmapd init script that seems to cause false positive in rpmlint (1.55 KB, application/octet-stream)
2010-01-28 22:20 EST, W. Michael Petullo
no flags Details

  None (edit)
Description W. Michael Petullo 2010-01-28 22:20:54 EST
Created attachment 387481 [details]
Dmapd init script that seems to cause false positive in rpmlint

Description of problem:
While submitting a dmapd to Fedora for review, my reviewer came across a false positive in rpmlint. To quote him:

- rpmlint reveals a new problem:
dmapd.i686: W: incoherent-subsys /etc/rc.d/init.d/dmapd $prog
Technically your solution seems to be OK as well, so I don't know why rpmlint
complains here...

It should be sufficient (and also not wrong) to replace 
lockfile=/var/lock/subsys/$prog
with
lockfile=/var/lock/subsys/dmapd

Version-Release number of selected component (if applicable):


How reproducible:
Every time

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Dmapd package review request:
https://bugzilla.redhat.com/show_bug.cgi?id=491497
Comment 1 Ville Skyttä 2010-01-29 11:19:55 EST
Known problem, documented in the "incoherent-subsys" message description.

$ rpmlint -I incoherent-subsys
incoherent-subsys:
The filename of your lock file in /var/lock/subsys/ is incoherent with your
actual init script name. For example, if your script name is httpd, you have
to use 'httpd' as the filename in your subsys directory. It is also possible
that rpmlint gets this wrong, especially if the init script contains
nontrivial shell variables and/or assignments.  These cases usually manifest
themselves when rpmlint reports that the subsys name starts a with '$'; in
these cases a warning instead of an error is reported and you should check the
script manually.

See also bug 210261 and http://rpmlint.zarb.org/cgi-bin/trac.cgi/ticket/51
(closing as UPSTREAM per the latter).

Note You need to log in before you can comment on or make changes to this bug.