Bug 560460 - Review Request: python-zbase32 - A base32 encoder/decoder
Summary: Review Request: python-zbase32 - A base32 encoder/decoder
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 560457
TreeView+ depends on / blocked
 
Reported: 2010-01-31 19:16 UTC by Ruben Kerkhof
Modified: 2015-02-09 14:41 UTC (History)
4 users (show)

Fixed In Version: python-zbase32-1.1.1-3.fc12
Clone Of:
Environment:
Last Closed: 2010-02-10 11:30:00 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ruben Kerkhof 2010-01-31 19:16:07 UTC
Spec URL: http://ruben.fedorapeople.org/python-zbase32.spec
SRPM URL: http://ruben.fedorapeople.org/python-zbase32-1.1.1-1.fc13.src.rpm
Description:
An alternate base32 encoder (not RFC 3548 compliant).

This is one of the dependencies of the Tahoe-LAFS project.

It's needed by pyutil (bz #560457) and needs pyutil itself, so to test this you have to install both in parallel.

Comment 1 Mamoru TASAKA 2010-02-01 18:50:21 UTC
(In reply to comment #0)
> It's needed by pyutil (bz #560457) and needs pyutil itself, so to test this you
> have to install both in parallel.    

... But how do you build python-zbase32 / pyutil on koji?

Comment 2 Ruben Kerkhof 2010-02-01 20:40:13 UTC
It should be possible to do a chain build.

I've disabled the dependency on pyutil to make reviewing easier. Once pyutil and zbase32 are in I'll do another build and enable the dependency.

Spec URL: http://ruben.fedorapeople.org/python-zbase32.spec
SRPM URL: http://ruben.fedorapeople.org/python-zbase32-1.1.1-2.fc13.src.rpm

Comment 3 Mamoru TASAKA 2010-02-06 17:27:26 UTC
Well, does not build.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1966640

Comment 4 Ruben Kerkhof 2010-02-09 17:04:41 UTC
Ah, sorry.

New version:
Spec URL: http://ruben.fedorapeople.org/python-zbase32.spec
SRPM URL: http://ruben.fedorapeople.org/python-zbase32-1.1.1-3.fc13.src.rpm

Comment 5 Mamoru TASAKA 2010-02-09 18:32:09 UTC
- Well, I don't know why you use %__python while you don't use
  such macros for other commands like rm, however this is not
  a blocker.

- About license:
--------------------------------------------------------
Copyright Only:	Almost all

BSD
./PKG-INFO
./zbase32.egg-info/PKG-INFO

LGPLv2 (strict)
./zbase32/zbase32id.py
---------------------------------------------------------
  license tag should be "BSD and LGPLv2" (well, actually
  I don't know why PKG-INFO says this is under BSD, however
  not a blocker)

Other things are okay. Please fix above.
----------------------------------------------------------
    This package (python-zbase32) is APPROVED by mtasaka
----------------------------------------------------------

Comment 6 Ruben Kerkhof 2010-02-09 18:56:03 UTC
Thanks Mamoru,

> - Well, I don't know why you use %__python while you don't use
>  such macros for other commands like rm, however this is not
>  a blocker.

It's the default template of rpmdev-newspec -t python. I'll changed it though.

> license tag should be "BSD and LGPLv2" (well, actually
> I don't know why PKG-INFO says this is under BSD, however
> not a blocker)

Ok, I'll ask upstream to clarify.

Comment 7 Ruben Kerkhof 2010-02-09 18:57:02 UTC
New Package CVS Request
=======================
Package Name: python-zbase32
Short Description: A base32 encoder/decoder
Owners: ruben
Branches: F-12

Comment 8 Jason Tibbitts 2010-02-09 21:07:05 UTC
CVS done (by process-cvs-requests.py).

Comment 9 Fedora Update System 2010-02-09 23:24:37 UTC
python-zbase32-1.1.1-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/python-zbase32-1.1.1-3.fc12

Comment 10 Fedora Update System 2010-02-20 00:10:13 UTC
python-zbase32-1.1.1-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Ruben Kerkhof 2010-03-15 15:15:50 UTC
Package Change Request
======================
Package Name: python-zbase32
New Branches: F-13
Owners: ruben

Comment 12 Mamoru TASAKA 2010-03-15 15:21:29 UTC
F-13 directory already exists.

Comment 13 anish 2015-02-09 14:06:46 UTC
Package Change Request
======================
Package Name: python-zbase32
New Branches: el6 epel7
Owners: anishpatil
InitialCC:

Comment 14 Gwyn Ciesla 2015-02-09 14:41:33 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.