Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 560696 - qpid-route route del - fails
qpid-route route del - fails
Status: CLOSED ERRATA
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: python-qpid (Show other bugs)
1.2
All Linux
medium Severity medium
: 1.2.2
: ---
Assigned To: Ted Ross
ppecka
:
Depends On:
Blocks: 729685
  Show dependency treegraph
 
Reported: 2010-02-01 11:36 EST by ppecka
Modified: 2011-08-10 10:23 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 729685 (view as bug list)
Environment:
Last Closed: 2010-10-07 21:50:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
reproducer (1.54 KB, application/x-shellscript)
2010-02-01 11:36 EST, ppecka
no flags Details
Patch that fixes this bug (519 bytes, patch)
2010-08-19 13:39 EDT, Ted Ross
no flags Details | Diff


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0756 normal SHIPPED_LIVE Moderate: Red Hat Enterprise MRG Messaging security and bug fix update 1.2.2 2010-10-07 21:49:47 EDT

  None (edit)
Description ppecka 2010-02-01 11:36:19 EST
Created attachment 388078 [details]
reproducer

Description of problem:
unable to delete existing route with qpid-route. 


How reproducible:
100%

Steps to Reproduce:
see attachment "reproducer"
  
Actual results:
Failed: SystemExit - 0

Expected results:
PASS

Additional info:
nothing suspicious found in qpidd logs
Comment 1 Ted Ross 2010-02-01 11:47:04 EST
What version of the qpid packages are you testing with?
Comment 2 ppecka 2010-02-01 12:48:59 EST
rpm -qa | grep qpid  
                             
qpidc-0.5.752581-34.el5
qpidd-xml-0.5.752581-34.el5
ruby-qpid-0.4.749380-2.el5
qpid-java-common-0.5.751061-9.el5
qpidc-ssl-0.5.752581-34.el5
qpidc-devel-0.5.752581-34.el5
qpidd-devel-0.5.752581-34.el5
qpid-java-client-0.5.751061-9.el5
qpidd-acl-0.5.752581-34.el5
qpidd-rdma-0.5.752581-34.el5
qpidc-perftest-0.5.752581-34.el5
python-qpid-0.5.752581-4.el5
qpidc-rdma-0.5.752581-34.el5
qpid-dotnet-0.4.738274-2.el5
qpidd-cluster-0.5.752581-34.el5
qpidd-ssl-0.5.752581-34.el5
qpidc-debuginfo-0.5.752581-34.el5
qpidd-0.5.752581-34.el5
Comment 3 ppecka 2010-07-15 08:38:28 EDT
The message "Failed: SystemExit - 0" after "qpid-route" seems to be confusing.
Isn't it better to just exit with proper return code without message like this?
Comment 4 Gordon Sim 2010-08-02 10:57:27 EDT
Still present for 1.3:

python-qmf-0.7.946106-5.el5
qpid-tools-0.7.946106-6.el5

Believe the change needed is:

Index: tools/src/py/qpid-route
===================================================================
--- tools/src/py/qpid-route	(revision 981525)
+++ tools/src/py/qpid-route	(working copy)
@@ -325,7 +325,7 @@
                     res = link.close()
                     if res.status != 0:
                         raise Exception("Error closing link: %d - %s" % (res.status, res.text))
-                sys.exit(0)
+                return
         if not _quiet:
             raise Exception("Route not found")
 
I.e. don't exit from the delRoute() method, return and let the normal exit path be followed.
Comment 5 Gordon Sim 2010-08-02 13:30:39 EDT
The issue with 1.2 appears to be a broker bug whereby the bridge is taken down (messages stop flowing), but the management object for the bridge still exists and never seems to be destroyed. This appears to have been fixed in 1.3 - can't yet see when/how.
Comment 7 Ted Ross 2010-08-17 14:50:11 EDT
I've moved this back to ASSIGNED and changed the target from 1.3 to 1.2.

This bug is fixed in 1.3 but still occurs in 1.2.  It may be necessary to engineer or back-port a fix into 1.2.
Comment 8 Ted Ross 2010-08-19 13:39:19 EDT
Created attachment 439743 [details]
Patch that fixes this bug
Comment 9 ppecka 2010-09-08 05:59:21 EDT
Verified for 1.3 on RHEL 5.5 i386 / x86_64

# rpm -qa | grep -P '(qpid|ais|qmf)' | sort -u
openais-0.80.6-16.el5_5.7
openais-devel-0.80.6-16.el5_5.7
python-qmf-0.7.946106-12.el5
python-qpid-0.7.946106-13.el5
qmf-0.7.946106-12.el5
qmf-devel-0.7.946106-12.el5
qpid-cpp-client-0.7.946106-12.el5
qpid-cpp-client-devel-0.7.946106-12.el5
qpid-cpp-client-devel-docs-0.7.946106-12.el5
qpid-cpp-client-ssl-0.7.946106-12.el5
qpid-cpp-mrg-debuginfo-0.7.946106-6.el5
qpid-cpp-server-0.7.946106-12.el5
qpid-cpp-server-cluster-0.7.946106-12.el5
qpid-cpp-server-devel-0.7.946106-12.el5
qpid-cpp-server-ssl-0.7.946106-12.el5
qpid-cpp-server-store-0.7.946106-12.el5
qpid-cpp-server-xml-0.7.946106-12.el5
qpid-java-client-0.7.946106-8.el5
qpid-java-common-0.7.946106-8.el5
qpid-tools-0.7.946106-10.el5

--> VERIFIED for 1.3
Comment 10 errata-xmlrpc 2010-10-07 21:50:39 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0756.html

Note You need to log in before you can comment on or make changes to this bug.