Spec URL: http://thomasj.fedorapeople.org/reviews/plasmoid-publictransport.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/plasmoid-publictransport-0.6.5-1.fc12.src.rpm Description: This applet shows a departure / arrival board for a given stop. It can also show journeys to or from the given "home stop". It gets it's information by parsing HTML/XML files from the web. You can get data for public transport, trains, ferries and planes (using flight-stats.com). It can be put into a panel and show the info in a pop up (Plasma::PopupApplet). You can set alarms for journeys and filter out journeys by type of vehicle or targets / origins. Supported Cities The data engine currently supports the following cities/regions by using different service providers, that can be changed in the configuration dialog of the applet: - Germany (using db.de, works for all cities and stops in Germany, also works for cities in other countries in Europe) - Switzerland (using sbb.ch, works for all cities and stops in Switzerland, also works for cities in other countries in Europe) - Austria (works for all cities in Austria) - Belgium (works for some/all? cities in Belgium) - Denmark (works for some/all? cities in Denmark) - USA (works for Southeastern Pennsylvania) - France (works for 168 stops in France, no local public transportation) - Slovakia (works for many cities in Slovakia with static data*, for Bratislava with dynamic data) - Czech (static data*) - Poland (static data*) Static data: May contain journeys that actually don't run today. In the "journey news" field you can view additional information about the journey (e.g. "runs Mo-Fr") when you view the additional information of a journey (context menu or double click). There are also some specialized accessors for German service providers. If "db.de" isn't working properly for you, you miss actual delay information for trams/buses/subways or you want the target/origin names to match the ones displayed on the vehicles (db.de appends the city name to it) you should try using one of the following. But mostly db.de works properly for all cities and it currently has the most features supported. - Lower Saxony / Bremen - Rhine-Main (this one uses an XML source, so the received data is smaller. It also includes delays for all vehicles) - Rhine-Neckar - Saxony-Anhalt - Stuttgart - Berlin - Dresden Airports in the whole world are supported through flightstats.com. It builds in mock. Rpmlint spits out some warnings about spelling-errors in %description that cant be corrected. [thomas@tusdell SPECS]$ rpmlint plasmoid-publictransport.spec ../SRPMS/plasmoid-publictransport-0.6.5-1.fc12.src.rpm ../RPMS/x86_64/plasmoid-publictransport-* plasmoid-publictransport.src: W: spelling-error %description -l en_US PopupApplet -> Mapplethorpe, Popularize, Populations plasmoid-publictransport.src: W: spelling-error %description -l en_US de -> DE, ed, d plasmoid-publictransport.src: W: spelling-error %description -l en_US sbb -> ebb, sob, sub plasmoid-publictransport.src: W: spelling-error %description -l en_US accessors -> accessory, accessorize, successors plasmoid-publictransport.src: W: spelling-error %description -l en_US Neckar -> Nectar, Necklace, Neckband plasmoid-publictransport.src: W: spelling-error %description -l en_US Anhalt -> An halt, An-halt, Asphalt plasmoid-publictransport.src: W: spelling-error %description -l en_US flightstats -> flight stats, flight-stats, flights tats plasmoid-publictransport.x86_64: W: spelling-error %description -l en_US PopupApplet -> Mapplethorpe, Popularize, Populations plasmoid-publictransport.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d plasmoid-publictransport.x86_64: W: spelling-error %description -l en_US sbb -> ebb, sob, sub plasmoid-publictransport.x86_64: W: spelling-error %description -l en_US accessors -> accessory, accessorize, successors plasmoid-publictransport.x86_64: W: spelling-error %description -l en_US Neckar -> Nectar, Necklace, Neckband plasmoid-publictransport.x86_64: W: spelling-error %description -l en_US Anhalt -> An halt, An-halt, Asphalt plasmoid-publictransport.x86_64: W: spelling-error %description -l en_US flightstats -> flight stats, flight-stats, flights tats 3 packages and 1 specfiles checked; 0 errors, 14 warnings.
LOL, the spelling "errors" and the suggested "fixes" are quite funny. This sounds cool and it claims to support all cities here in Austria, I guess I'll just have to review this. :-)
First observation: Your specfile claims "License: GPLv3+", but according to the headers on the source files, this is actually LGPLv2+. (Don't ask me why it ships only with a GPLv3 COPYING, I don't see a copy of the LGPLv3 nor any version of he LGPLv2 (2 or 2.1), but the source file headers should normally be trusted more. Still, getting upstream to ship a copy of at least one version of the LGPL would be nice.)
SRPM Url: http://thomasj.fedorapeople.org/reviews/plasmoid-publictransport-0.6.9-1.fc12.src.rpm SPEC Url: http://thomasj.fedorapeople.org/reviews/plasmoid-publictransport.spec - New upstream source 0.6.9 - Changed License to LGPLv2+ - Sent mail to upstream for correct license inclusion (via kde-look.org interface)
Shouldn't this be called kde-plasma-publictransport like all the other plasmoids?
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117
This review request is clearly abandoned (the spec link is dead). In addition, the upstream code has not been ported to Plasma 5 and does thus not work on Fedora 22 and newer.