SPEC: http://pbrobinson.fedorapeople.org/libimobiledevice.spec SRPM: http://pbrobinson.fedorapeople.org/libimobiledevice-0.9.7-1.fc12.src.rpm Description: libimobiledevice is a library for connecting to mobile devices including phones and music players Original library review request: https://bugzilla.redhat.com/show_bug.cgi?id=473590
Shamelessly copied from Notting's original review. MUST items: - Package meets naming and packaging guidelines - OK - Spec file matches base package name. - OK - Spec has consistent macro usage. - OK - Meets Packaging Guidelines. OK - License - LGPLv2+ - OK - License field in spec matches - OK - License file included in package - OK - Spec in American English - OK - Spec is legible. - OK - Sources match upstream md5sum: - Package needs ExcludeArch - OK - BuildRequires correct - OK - Spec handles locales/find_lang - N/A - Package is relocatable and has a reason to be. - N/A - Package has %defattr and permissions on files is good. - OK - Package has a correct %clean section. - OK - Package has correct buildroot - OK - Package is code or permissible content. - OK - Doc subpackage needed/used. - OK - Packages %doc files don't affect runtime. - OK - Headers/static libs in -devel subpackage. - OK - Spec has needed ldconfig in post and postun - OK - .pc files in -devel subpackage/requires pkgconfig - OK - .so files in -devel subpackage. - OK - -devel package Requires: %{name} = %{version}-%{release} - OK - .la files are removed. - OK - Package compiles and builds on at least one arch. - Tested x86_64 (w/mock) - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. - OK - Package owns all the directories it creates. - OK - No rpmlint output. - final provides and requires are sane: SHOULD Items: - Should build in mock. - http://koji.fedoraproject.org/koji/taskinfo?taskID=1957532 - OK - Should function as described. - Same code as libiphone - Should have sane scriptlets. - OK - Should have subpackages require base package with fully versioned depend. - OK - Should have dist tag - OK - Should package latest version - OK So, for approval: - Include devel docs (they're in docs/html, bonus points for writing out a devhelp browseable - Remove libiphone obsoletes and requires, the library isn't compatible, and both versions should be parallel installable anyway
> So, for approval: > - Include devel docs (they're in docs/html, bonus points for writing out a > devhelp browseable Added the docs. Will look at the devhelp browseable shortly. > - Remove libiphone obsoletes and requires, the library isn't compatible, and > both versions should be parallel installable anyway Added due to https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages Even though they are not compatible if we don't have the obsoletes/provides we end up getting left with the libiphone package which will have conflict issues on upgrades with libplist/ifuse/gvfs-afc SPEC: http://pbrobinson.fedorapeople.org/libimobiledevice.spec SRPM: http://pbrobinson.fedorapeople.org/libimobiledevice-0.9.7-2.fc12.src.rpm
OK, fair enough.
New Package CVS Request ======================= Package Name: libimobiledevice Short Description: Library for connecting to mobile devices Owners: pbrobinson Branches: F-12 F-11 InitialCC:
CVS done (by process-cvs-requests.py).
Built and in rawhide. Will test F-12/F-11 in the next couple of days and get them pushed out as well.