Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/devmon/devmon.spec SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/devmon/devmon-0.3.1-0_beta1el5.src.rpm Description: Devmon is a device monitoring script which works in tandem with the Hobbit/BigBrother monitoring suites. It queries remote hosts via SNMP, applies user-defined logic and thresholds to the acquired data, and submits status and alarms to a display server. rpmlint output [root@rpm02 SPECS]# rpmlint /var/lib/mock/hp-rhel-5-x86_64/result/devmon-0.3.1-0_beta1.el5.src.rpm devmon.spec 1 packages and 1 specfiles checked; 0 errors, 0 warnings. [root@rpm02 SPECS]# Related to devmon-templates (BZ #560852)
Why don't you use attr(-,root,root,-) and not attr(-,root,root) everywhere? %attr(755,root,root) %{_datadir}/%{name}/devmon ? Shouldn't this be %{_datadir}/%{name}/ ? The templates are installed into this subfolder, so devmon-templates needs to require this package.
(In reply to comment #1) > Why don't you use attr(-,root,root,-) and not attr(-,root,root) everywhere? Sounds a bit strange^^ Means: Replace the latter with the first ;)
Hi and thanks for reviewing. I'll have to look at the syntax again... I'm considering rolling devmon and devmon-templates into a single package to resolve the circular dependencies. What are your thoughts on that? --- %attr(755,root,root) %{_datadir}/%{name}/devmon ? Shouldn't this be %{_datadir}/%{name}/ ? --- This is the devmon daemon itself. It should be in /usr/bin. I'll address this tomorrow and upload again. Thanks again CC
spec and srpm updated. Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/devmon/devmon.spec SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/devmon/devmon-0.3.1-1_beta1.el5.src.rpm When you say 'attr(-,root,root,-)' do you mean 'defattr(-,root,root,-)'? Thanks CC
oops, forgot to update rpmlint output --- [root@rpm02 SPECS]# rpmlint devmon.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [root@rpm02 SPECS]# rpmlint /var/lib/mock/hp-rhel-5-x86_64/result/devmon-0.3.1-1_beta1.el5.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ---
(In reply to comment #4) > When you say 'attr(-,root,root,-)' do you mean 'defattr(-,root,root,-)'? I mean both. (In reply to comment #3) > Hi and thanks for reviewing. I don't intent to review this for now. I just noticed your wrong %files section. ;) > I'm considering rolling devmon and devmon-templates into a single package to > resolve the circular dependencies. What are your thoughts on that? Hmm, I don't see atm where the circular dependencies come from (but also didn't look that close). Will you always update both packages in parallel or sometimes one or the other? If you always update both packages in parallel, you should make one spec, if not, better make two.
Hi > I don't intent to review this for now. I just noticed your wrong %files > section. ;) OK, no probs The circular dependency is the devmon daemon is useless without the templates, but the templates require a directory owned by the devmon package. I'll look again at the attr macros use. CC
OK, I think this RPM is a lot better now. http://members.iinet.net.au/~coec/RPMS_for_review/devmon/devmon-0.3.1-4_20100211.el5.src.rpm Note though that there is an unresolved bug with devmon that I've only recently become aware of where devmon stops reporting to bigbrother/hobbit (AKA xymon). People are actively attempting to identify the cause of this bug. CC