Spec URL: http://www.bachelot.org/fedora/SPECS/perl-String-Escape.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-String-Escape-2010.002-1.fc12.src.rpm Description: This module provides a flexible calling interface to some frequently- performed string conversion functions, including applying and expanding standard C/Unix-style backslash escapes like \n and \t, wrapping and removing double-quotes, and truncating to fit within a desired length.
And here: Requires: perl(Test::More) is suspect as well...
Same reasoning as the other one, I'll remove it. Anything else ?
Not at the moment. Put up a new spec/srpm and I'll review :)
New version : - Remove unwanted Requires: perl(Test::More). Spec URL: http://www.bachelot.org/fedora/SPECS/perl-String-Escape.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-String-Escape-2010.002-2.fc12.src.rpm
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1983996
Hmmm... I'm seeing a 404 error when trying to fetch the upstream tarball. [cweyl@athena bin]$ wget http://www.cpan.org/modules/by-module/String/String-Escape-2010.002.tar.gz --2010-02-13 11:41:37-- http://www.cpan.org/modules/by-module/String/String-Escape-2010.002.tar.gz Resolving www.cpan.org... 207.171.7.177 Connecting to www.cpan.org|207.171.7.177|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2010-02-13 11:41:37 ERROR 404: Not Found.
Hohum, the tarball is not at the canonical location... Fixed in : Spec URL: http://www.bachelot.org/fedora/SPECS/perl-String-Escape.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-String-Escape-2010.002-3.fc12.src.rpm
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2001007
Looks good, with a couple recommendations: Given the recent issues with ExtUtils::MakeMaker and PERL_INSTALL_ROOT, you will probably want to replace PERL_INSTALL_ROOT with DESTDIR under %install. Please consider adding "%{?perl_default_filter}" to your spec, before the %description block; even if the addition is merely pro-forma for this package. It won't hurt anything and may well save some pain in the future. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2001007 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): d90f5d2f7146905ce314fe8b295848c8ac3b934c String-Escape-2010.002.tar.gz d90f5d2f7146905ce314fe8b295848c8ac3b934c String-Escape-2010.002.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-String-Escape-2010.002-3.fc13.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-String-Escape-2010.002-3.fc13.noarch.rpm perl(String::Escape) = 2010.002 perl-String-Escape = 2010.002-3.fc13 ====> requires for perl-String-Escape-2010.002-3.fc13.noarch.rpm perl(Carp) perl(Exporter) perl(:MODULE_COMPAT_5.10.1) perl(strict) perl(vars) perl(warnings) =====> perl-String-Escape-2010.002-3.fc13.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-String-Escape-2010.002-3.fc13.src.rpm ====> requires for perl-String-Escape-2010.002-3.fc13.src.rpm perl(ExtUtils::MakeMaker) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) APPROVED
Thanks for the review Chris New Package CVS Request ======================= Package Name: perl-String-Escape Short Description: String::Escape Perl module Owners: xavierb Branches: F-11 F-12 F-13 EL-5 InitialCC: perl-sig
CVS done (by process-cvs-requests.py).
perl-String-Escape-2010.002-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc12
perl-String-Escape-2010.002-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.el5
perl-String-Escape-2010.002-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc13
perl-String-Escape-2010.002-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-String-Escape-2010.002-3.fc11
perl-String-Escape-2010.002-3.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Escape'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-2292
perl-String-Escape-2010.002-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Escape'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-2469
perl-String-Escape-2010.002-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Escape'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2597
perl-String-Escape-2010.002-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Escape'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-2603
perl-String-Escape-2010.002-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
perl-String-Escape-2010.002-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
perl-String-Escape-2010.002-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-String-Escape-2010.002-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.