Bug 561141 - Incorrect Icon= entry in fedora-abe.desktop
Summary: Incorrect Icon= entry in fedora-abe.desktop
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: abe
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Wart
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-02 20:13 UTC by Kevin Kofler
Modified: 2010-11-04 15:40 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-04 15:40:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Kevin Kofler 2010-02-02 20:13:50 UTC
Description of problem:
The icon does not show up in the KDE menu because /usr/share/applications/fedora-abe.desktop contains:
Icon=abe.png
This should use the full path, i.e.:
Icon=/usr/share/pixmaps/abe.png
or preferably, the freedesktop.org icon theming spec should be followed for the icon (but the problem is that its 32×24 size is not any standard icon size).

Version-Release number of selected component (if applicable):
abe-1.1-11.fc12.i686

How reproducible:
Always.

Steps to Reproduce:
1. Open KDE menu.
  
Actual results:
No icon shown for Abe.

Expected results:
Icon shown for Abe.

Additional info:
If you decide to go the freedesktop.org way, you need to:
1. install the icon to /usr/share/icons/hicolor/32x32/apps/abe.png (or one of the other standard sizes; please note that the icon should actually be of that size)
2. add Requires: hicolor-icon-theme for directory ownership
3. follow https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
4. reference the icon in the .desktop file using just Icon=abe (not abe.png)

The advantages are that you can provide multiple sizes and that the icon is themable. (In addition, /usr/share/pixmaps is deprecated.)

But the easiest solution is to just use the full path, i.e.:
Icon=/usr/share/pixmaps/abe.png

Comment 1 Bug Zapper 2010-11-03 23:14:20 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Kevin Kofler 2010-11-03 23:22:27 UTC
This bug is still not fixed in Rawhide nor any Fedora release.

Comment 3 Kevin Kofler 2010-11-04 15:40:32 UTC
FWIW, KDE actually accepts Icon=abe.png these days (tested 4.4.5), so the icon shows up. Whether the entry is compliant to specs is up for debate. The relevant spec:
http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
says:
"Icon to display in file manager, menus, etc. If the name is an absolute path, the given file will be used. If the name is not an absolute path, the algorithm described in the Icon Theme Specification will be used to locate the icon."
and as referenced:
http://standards.freedesktop.org/icon-theme-spec/latest/ar01s05.html
(Icon Lookup) says nothing about /usr/share/pixmaps, but the Directory Layout section of the Icon Theme Specification:
http://standards.freedesktop.org/icon-theme-spec/latest/ar01s03.html
says:
"By default, apps should look in $HOME/.icons (for backwards compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order)."

So, is it valid to use just a file name for an icon in /usr/share/pixmaps? I don't know. But since it actually works now, let's close this bug.


Note You need to log in before you can comment on or make changes to this bug.