Hide Forgot
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec SRPM URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-1.fc12.src.rpm Description: The XKBC engine for IBus platform. It provides keyboard layout emulation input method. This is my first package, and please sponsor me.
Build failed in koji. http://koji.fedoraproject.org/koji/taskinfo?taskID=1960480
Ok once package is ready, happy to do final review and sponsor you.
Modified spec file, and re-build against dist-f12, build succeeded: http://koji.fedoraproject.org/koji/taskinfo?taskID=1960564 Thanks for the help and review.
You need to post the new spec file and bumped srpm for every update...
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec SRPM URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-2.fc12.src.rpm Thanks for the reviews.
Package Review + package builds in mock (rawhide noarch). http://koji.fedoraproject.org/koji/taskinfo?taskID=1962396 + rpmlint is no errors and warnings + source files match upstream url 939e3d5f68946dfecedb737954f15c24 ibus-xkbc-1.2.0.20100115.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package does not contain code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + No update-gtk-immodules scriptlets present. + no duplicates in %files. + file permissions are appropriate. + no Desktop files. + Package => ibus-xkbc-1.2.0.20100115-2.fc13.noarch.rpm Provide: ibus-xkbc = 1.2.0.20100115-2.fc13 Requires: /bin/bash ibus >= 1.2.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Approved
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec SRPM URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-3.fc12.src.rpm Updated source package.
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec SRPM URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-4.fc12.src.rpm Sorry for missing the changed detail of the previous changes, so add it to the change log, and also post it here. Thanks for review. This time fixes the change log continuation, and the new entire change log is: * Wed Feb 04 2010 Peng Wu <pwu@redhat.com> - 1.2.0.20100115-4 - Fixes change logs continuation. * Wed Feb 04 2010 Peng Wu <pwu@redhat.com> - 1.2.0.20100115-3 - Correct home page url. * Wed Feb 04 2010 Peng Wu <pwu@redhat.com> - 1.2.0.20100115-2 - Fixes koji build for F-13. * Wed Feb 03 2010 Peng Wu <pwu@redhat.com> - 1.2.0.20100115-1 - The first version.
Thanks, taking over final review for sponsorship. I tested the package and it seems to work pretty well. I don't see any problems with the package and have verified the review above on the latest package. Package is APPROVED and I am sponsoring pwu.
Welcome. And re-factor the change log of rpm spec. New package is here. Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec SRPM URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-3.fc12.src.rpm And new change log: %changelog * Wed Feb 04 2010 Peng Wu <pwu@redhat.com> - 1.2.0.20100115-3 - Correct home page url. * Wed Feb 04 2010 Peng Wu <pwu@redhat.com> - 1.2.0.20100115-2 - Fixes koji build for F-13. * Fri Oct 30 2009 Naoyuki Ishimura <naoyuki.ishimura@sun.com> - 0.1.0-1 - The first version.
New Package CVS Request ======================= Package Name: ibus-xkbc Short Description: The XKBC engine for IBus input platform Owners: pwu Branches: F-12 F-13 InitialCC: petersen phuang i18n-team
No F-13 branches yet. cvs admin done
Package is imported by koji, by using the following command: $./common/cvs-import.sh ../ibus-xkbc-1.2.0.20100115-3.fc12.src.rpm $./common/cvs-import.sh -b F-12 ../ibus-xkbc-1.2.0.20100115-3.fc12.src.rpm
ibus-xkbc-1.2.0.20100115-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ibus-xkbc-1.2.0.20100115-3.fc12
ibus-xkbc-1.2.0.20100115-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.