Spec URL: http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-jta.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-jta-1.1.1-1.fc12.src.rpm Description: This package splits just the jta-1.1 components of the giant monolithic geronimo-specs spec. Requires geronimo-parent-poms.
I'm taking this one.
Updated version with better descriptions and cleaned-up Provides and Obsoletes: Spec URL: http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-jta.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-jta-1.1.1-2.fc12.src.rpm
Review: NOTOK: rpmlint must be run on every package. Warnings: geronimo-jta.src:27: W: unversioned-explicit-obsoletes geronimo-specs geronimo-jta.spec:27: W: unversioned-explicit-obsoletes geronimo-specs Should be fixed. Please put a version for the obsoletes geronimo-jta.noarch: W: obsolete-not-provided geronimo-specs geronimo-jta.noarch: W: non-conffile-in-etc /etc/maven/fragments/geronimo-jta Both are not a problem as we really want to obsolete and the second one is just how maven works. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Fetch instructions provided. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. OK: Each package must have a %clean section, which contains rm -rf %{buildroot} OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: All filenames in rpm packages must be valid UTF-8. Please fix the unversioned obsolete and the package is good.
added versioned Obsoletes Spec URL: http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-jta.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-jta-1.1.1-4.fc12.src.rpm
Package is APPROVED.
New Package CVS Request ======================= Package Name: geronimo-jta Short Description: J2EE JTA v1.1 API Owners: mef Branches: F-12
CVS done (by process-cvs-requests.py).